search

Entle / action-pagerduty-alert

MIT License
8 stars 32 forks source link

Support for dedupe key #2

Closed szunami closed 3 years ago

szunami commented 3 years ago

Addresses #1 , cc @JohJonker

szunami commented 3 years ago

@JohJonker I think this PR is ready for another look.

szunami commented 3 years ago

@JohJonker any chance you have the time to review this? :)

JohJonker commented 3 years ago

Hi @szunami, apologies for the delay. Thanks for making the changes! This looks good. I'm just going to rename the dedup_key input parameter to dedup-key after approving the PR if that's fine by you, for consistency with the existing parameter.

szunami commented 3 years ago

Sounds good to me; when you feel comfortable with this, would you mind cutting a release?

JohJonker commented 3 years ago

Sure! I'll have it ready in the next 15-30 mins.