search

Entoarox / StardewMods

My updated mods repository
36 stars 37 forks source link

Smapi 2.6 update #45

Closed Slamerz closed 6 years ago

Slamerz commented 6 years ago

Compiling and running error free. Just need to test fix up some mods to fully test its features.

Entoarox commented 6 years ago

I cannot at this time accept the pull, as a cursory inspection has shown me things that your changes broke.

Most important of these right now is handling items in chests, as I do not see you properly deal with those.

Further, some of your modified loops are in a inefficient order, having repeated checks where only 1 is needed (ef_bushreset logic being the stand-out culprit I noticed)

Finally, I use the same style rules as SMAPI itself, so unless Pathos has changed those rules since I last worked on the project, methods always have to be fully bodied.

Otherwise, you have done a lot of work, and once I am certain that you fix the issues I've brought up, I will gladly run a beta round for 1.3 crediting you for doing the update work.