Entoarox / StardewMods

My updated mods repository
36 stars 37 forks source link

Seasonal tilesheets with non-seasonal attributes #8

Closed Androxilogin closed 7 years ago

Androxilogin commented 7 years ago

When using a tilesheet that has the ability for seasonal counterparts but set to '"Seasonal": false' so to load only from one tilesheet to a specified map, this will display tile errors. Not sure if this is an error or even preventable.

{
  "MapName": "SeedShop",
  "FileName": "SeedShop",
  "SheetId": "additions",
  "Seasonal": false
},
{
  "MapName": "Forest",
  "FileName": "Forest",
  "SheetId": "additions",
  "Seasonal": true
}
Entoarox commented 7 years ago

@Androxilogin Question, in the first case, SeedShop, does SeedShop.xnb exist, and do all 4 Forest_<season>.xnb files exist for the second? The same sheet Id being used for 2 separate files in 2 separate locations should have no effect.

Androxilogin commented 7 years ago

Your first question, when you say exist do you mean set as an override? If so, yes.

I suppose I didn't exactly clarify the issue properly. I apologize, running through things to generate a report. These were from the same manifest. The 4 seasons do exist and function properly however the problem is that using also a non-seasonal setting to another map will not work even with a defined (additions_spring.xnb) season. It's not a big concern, just a chance to use less tilesheets.

Entoarox commented 7 years ago

You have SheetId as "additions", not FileName, it is FileName that references the xnb file for the tilesheet.

But if I understand, you have a xnb file called additions_<season>.xnb for each season, correct? In that case, when adding it as a non-seasonal tilesheet, you need to specify the season in the FileName (additions_spring for example) The Seasonal flag means that ALL will automatically append _<season> to the FileName and updates the sheet each season to reference the new season.

Androxilogin commented 7 years ago

Yes, I tried references to specified seasons as well but that was before all of these later updates so this may actually be resolved. Having it seasonal on one map and use a single sheet on another simul. shouldn't be a problem though, correct? (When written in the manifest correctly, anyway).

Entoarox commented 7 years ago

No it shouldnt, provided you tell what seasonal version to use in the non-seasonal map, since the whole seasonal system is about adding a _ suffix and updating the seasonal tilesheets each season, while non-seasonal tilesheets are left as-is, no addition to the name or updating during any time the game is active.

Entoarox commented 7 years ago

Closing this as resolved.