Entoarox / StardewMods

My updated mods repository
36 stars 37 forks source link

Framework 2.5.4 breaks loading save files #85

Closed rikai closed 3 years ago

rikai commented 3 years ago

Hello, updated to 2.5.4 this morning and loading my existing save breaks:

https://smapi.io/log/fe8abda3d577404f81fb7c84135ab99a

Reverting to 2.5.3 allows the save to load.

Based on the log, it may be a conflict with SpaceCore, but I'm really not sure?

Entoarox commented 3 years ago

Issue is a NRE in the loading override by space, I am assuming that EF replacing the serializer prevents this NRE in spaceCore from happening, so probably not a EF bug so much as a SpaceCore bug that older versions of EF hid.

Please try loading without EF at all, and if the bug persists, then this is truly a issue with the latest SpaceCore release.

rikai commented 3 years ago

Hey! I have tried both loading without the framework while still having SpaceCore (the issue does not happen) as well as loading with the previous version of the framework while still having SpaceCore.

The issue does not appear in either case. It is only with 2.5.4 that this issue appears as far as I can tell.

Entoarox commented 3 years ago

Issue has been identified and fixed in 2.5.5