search

Entropy-Foundation / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptoslabs.com
Other
0 stars 2 forks source link

Investigate whether it is safe to make `allow_validator_set_change` dynamically configurable #72

Closed isaacdoidge closed 1 month ago

isaacdoidge commented 2 months ago

allow_validator_set_change in staking_config.move can currently only be set at genesis. It would be useful if we could change it at runtime via governance so that we can control the size of the network during its early life. We need to investigate where this value is used so that we can determine if it is safe to make this change.

It should not be possible to update this value in a fully decentralised network, since a malicious majority should not be able to lock honest parties out of the network. Accordingly, we should also add a function that allows us to permanently deactivate this functionality. We can call it before moving from foundation-controlled governance to proper decentralised governance.

isaacdoidge commented 1 month ago

Addressed by #77.

isaacdoidge commented 1 month ago

In the end we decided not to add the function for permanently disabling changes to allow_validator_set_change because we will need to do a framework upgrade to change the governance model anyway, at which time we can change the implementation of the update method to assert false.