Updated ipython_version.t to reflect current jupyter/ipython output

EntropyOrg / p5-Devel-IPerl

:microscope::books: Perl5 language kernel for Jupyter <http://jupyter.org/>

http://p3rl.org/Devel::IPerl

93 stars 15 forks source link

Updated ipython_version.t to reflect current jupyter/ipython output #97

Closed joelandman closed 3 years ago

joelandman commented 5 years ago

Modern ipython outputs information like this

ipython --version
7.6.1

And jupyter

jupyter --version
jupyter core     : 4.5.0
jupyter-notebook : 5.7.8
qtconsole        : 4.5.1
ipython          : 7.6.1
ipykernel        : 5.1.1
jupyter client   : 5.3.0
jupyter lab      : not installed
nbconvert        : 5.5.0
ipywidgets       : 7.5.0
nbformat         : 4.4.0
traitlets        : 4.3.2

This patch adjusts the ipython_version.t test to correctly handle the modern output formats.

coveralls commented 5 years ago

Coverage remained the same at 76.111% when pulling 312c76301ad0cfa02ce7b5db1f4a68e00ba75f7e on joelandman:joelandman-ipython_version_patch-1 into 0f9fe2f1470a347705b5ce5bac7fa8fb40904869 on EntropyOrg:master.

joelandman commented 5 years ago

It looks like the mac test failed, but not due to the module or patch. Rather it was a problem with the version of zmq being installed requiring a newer version of python.

err

FWIW: I've applied this patch manually to a working homebrew based mac install. It works fine. Please consider applying this, as the module will not pass tests on modern ipython/jupyter installations without it.

zmughal commented 3 years ago

Thanks! Sorry for the delay in getting this in.

I'll be fixing the CI soon, so we'll ignore the CI failures for now.