EntrustCorporation / draft-ounsworth-composite-sigs

IETF Internet-Draft about X.509 certificates with composite keys and signatures
Other
5 stars 4 forks source link

Version 10 changes to composite signatures #110

Closed johngray-dev closed 8 months ago

johngray-dev commented 9 months ago

Here is the pull request with the updates for composite signatures:

Changes affecting interoperability:

Editorial changes:

janklaussner commented 8 months ago

Hi @johngray-dev, @ounsworth , @opencrypto

I finished the review and have some minor comments. If you agree I can gladly change them myself:

line 126: shall we still mention {{I-D.ounsworth-pq-composite-keys}}? I think we can remove this section already since we define structures for public and private keys now...

line 166: I want to add a third point:

  • Safeguard against faulty algorithm implementations and compromised keys: Even for long known algorithms there is a non-negligible risk of severe implementation faults. Latest examples are the ROCA attack and ECDSA psychic signatures. Using more than one algorithms will also mitigate these risks.

line 318: here we say generation must fail on recursive composites, but the pseudo code does not include a check step like in the verification. Shall I add one for sake of uniformity?

line 320: I think this sentence has duplicate sections, I commited a fixed version.