Envek / obs-studio-node-example

Learn how to use OBS Studio from your Electron app for screen video recording
GNU General Public License v2.0
105 stars 19 forks source link

Electron 10 #25

Closed hrueger closed 4 years ago

hrueger commented 4 years ago

fixes #1

Can someone check if that works on MacOS, too?

kurdin commented 4 years ago

@hrueger on Mac I have error

Error: The module '/Users/xxx/projects/tmp/tmp/obs-studio-node-example/node_modules/node-window-rendering/node_window_rendering.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 73. This version of Node.js requires
NODE_MODULE_VERSION 82. Please try re-compiling or re-installing

for mac in package.json I use "node-window-rendering": "https://slobs-node-window-rendering.s3-us-west-2.amazonaws.com/node-window-rendering-1.0.12-osx.tar.gz",

seems like node-window-rendering release does not support Electron 10 yet

hrueger commented 4 years ago

@kurdin is that the latest version of node-window-rendering?

You can find the latest version by cloning https://github.com/stream-labs/streamlabs-obs, running npm i and having a look at the output.

hrueger commented 4 years ago

@alse @chfeizy you seem to have a Mac, too. Could you check if this PR is working for you?

Envek commented 4 years ago

@hrueger I'm super excited to get fresh Electron version (with modern JS goodies)! Thank you very much!

However I had no time to review it yet, sorry. I will try to get to it in a couple of days.

Envek commented 4 years ago

Thank you very much for update! 🙏

If someone will have problems on MacOS, let them create new issue for it.

psd-coder commented 4 years ago

@hrueger Hi! I have the same result as @kurdin on Mac. And mentioned version of node-window-rendering is the latest from the obs-studio-node repository.

hrueger commented 4 years ago

@psd-coder Hm. Can you please create a new issue for that?

hrueger commented 4 years ago

@Envek I got the info that osn now works with Electron 10 from this comment but it seems like streamlabs-obs is still using Electron 6...