Enveloppe / obsidian-enveloppe

Enveloppe helps you to publish your notes on a GitHub repository from your Obsidian Vault, for free!
https://enveloppe.github.io/
Apache License 2.0
636 stars 39 forks source link

[FR]: Convert Inline Dataview Queries to Markdown #320

Closed wychwitch closed 8 months ago

wychwitch commented 8 months ago

Issue validation

Is your feature related to a problem ?

No response

What solution do you want to see ?

The Dataview to markdown converter works great for dataview blocks, however inline-dataview blocks don't convert to markdown like the dataview blocks! Instead they are removed once the file is parsed.

So something such as

= this.property doesn't display the files property like it does in obsidian

While

LIST #tag

Works and displays everything as normal.

Describe the alternative you've considered

No response

OS

Windows

Anything else?

No response

Plugin version

7.0.0

Obsidian version & debug log

SYSTEM INFO:
    Obsidian version: v1.5.8
    Installer version: v1.4.13
    Operating system: Windows 10 Home 10.0.22621
    Login status: logged in
    Catalyst license: insider
    Insider build toggle: on
    Live preview: on
    Base theme: light
    Community theme: none
    Snippets enabled: 6
    Restricted mode: off
    Plugins installed: 93
    Plugins enabled: 84
        1: Charts View v1.2.7
        2: Divide & Conquer v1.0.0
        3: Minimal Theme Settings v7.3.1
        4: Calendar v1.5.10
        5: Buttons v0.5.1
        6: Canvas Links v1.1.4
        7: Annotator v0.2.11
        8: April's Automatic Timelines v0.13.2
        9: Archiver v0.26.1
        10: Crossbow v1.4.0
        11: Contextual Typography v2.2.5
        12: Commander v0.5.1
        13: Colorful Note Borders v0.2.4
        14: Chem v0.3.0
        15: Advanced Tables v0.21.0
        16: Colored Tags v5.0.0
        17: Color Palette v2.2.0
        18: Badges v1.1.0
        19: Set Mobile Theme v0.2.0
        20: Codename v1.0.0
        21: Admonition v10.2.0
        22: Time Ruler v2.2.0
        23: Templater v2.2.1
        24: TagFolder v0.18.5
        25: Table Extended v1.6.1
        26: Supercharged Links v0.11.1
        27: Style Settings v1.0.7
        28: Sortable v0.3.1
        29: Soomda v1.0.4
        30: Solve v0.9.0
        31: Shukuchi v0.4.1
        32: Settings Search v1.3.10
        33: QuickAdd v1.7.0
        34: Reading View Enhancer v0.1.4
        35: Quick Switcher++ v4.0.0
        36: Projects v1.17.1
        37: Plugin Manager v0.1.5
        38: Periodic Notes v0.0.17
        39: Outliner v4.8.0
        40: BRAT v0.8.4
        41: Math+ v0.7.0
        42: Mood Tracker v1.2.1
        43: MetaEdit v1.8.2
        44: Lovely-Mindmap v1.0.1
        45: Linter v1.22.0
        46: Leader Hotkeys v0.2.1
        47: Latex Environments v0.4.2
        48: Kanban v1.5.3
        49: Juggl v1.5.0
        50: Improved VimCursor v0.0.1
        51: ICS v1.6.1
        52: JS Engine v0.1.1
        53: Homepage v3.7.0
        54: Heatmap Calendar v0.6.0
        55: Habit Calendar v1.2.0
        56: Find orphaned files and broken links v1.9.1
        57: Full Calendar v0.10.7
        58: Force note view mode v1.2.2
        59: Folder notes v1.7.14
        60: File Diff v1.1.1
        61: File Color v1.1.0
        62: Email code block v0.6.0
        63: Desmos v0.6.6
        64: Dataview v0.5.64
        65: Data Entry v9.0.1
        66: Footnote Shortcut v0.1.3
        67: Colored Text v1.0.0
        68: @ Symbol Linking v1.6.2
        69: Markdown Table Editor v0.3.1
        70: Breadcrumbs v3.6.11
        71: Github Publisher v7.0.0
        72: Meta Bind v0.12.5
        73: Emoji Magic v0.2.2
        74: Iconize v2.10.1
        75: File Explorer++ v1.1.4
        76: Typing v0.3.7
        77: Object Writer v1.0.0
        78: Ribbon Divider v1.0.0
        79: Pomodoro Timer v1.1.9
        80: Tasks v6.0.0
        81: File Property Enhancer v1.1.1
        82: Multi Properties v1.0.0
        83: Dice Roller v10.4.5
        84: Rant-Lang v0.5.9

RECOMMENDATIONS:
    Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
    Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.
Mara-Li commented 8 months ago

Dataview is in maintenance mode, I can't update the API often and is bugged. I already said a lot about it. Until the updating of the API is not properly fixed, I can't fix any bug in the conversion, mainly for inline :/

See blacksmithgu/obsidian-dataview#2080

Mara-Li commented 8 months ago

I have some Inline that works (for example = this.propery) on my side, but sometimes, not. Dunno why /:

wychwitch commented 8 months ago

Dataview is in maintenance mode, I can't update the API often and is bugged. I already said a lot about it. Until the updating of the API is not properly fixed, I can't fix any bug in the conversion, mainly for inline :/

See blacksmithgu/obsidian-dataview#2080

Baahhh that sucks, thank you anyways!

Mara-Li commented 8 months ago

TBH it's strange it doesn't work on your side, as I successfully convert simple inline (like = this.birthday when birthday is a property (frontmatter) date.

wychwitch commented 8 months ago

TBH it's strange it doesn't work on your side, as I successfully convert simple inline (like = this.birthday when birthday is a property (frontmatter) date.

Oh wow, it's specifically with number property type! Dates are preserved fine (I just tried with the = this.birthday example) but if it's set to a number it screws up

I'll try some other types?? that is so weird, I would think numbers should be easiest

Mara-Li commented 8 months ago

Number works on my side 😅

wychwitch commented 8 months ago

OH I FIGURED IT OUT!! IT'S ZEROES, for some reason if the number field has a zero it simply wont work, otherwise any other number works fine! This is, really weird? Maybe it's a falsy/truthy condition being triggered?

Mara-Li commented 8 months ago

Oh my god it's explain also a field that don't want to trigger on my side! Thank! In any case, maybe an issue should be opened in the Dataview repository!

wychwitch commented 7 months ago

I just wanted to come back and share that I was able to get around 0's not being displayed as explicitly casting them as string , like = string(this.DEX)! Now I can update or perform calcs and itll be fine

Mara-Li commented 7 months ago

Thanks!