Enveloppe / obsidian-enveloppe

Enveloppe helps you to publish your notes on a GitHub repository from your Obsidian Vault, for free!
https://enveloppe.github.io/
Apache License 2.0
636 stars 39 forks source link

[Bug]: excalidraw is transformed to svg,bug the link path is not changed #331

Closed JayClock closed 6 months ago

JayClock commented 6 months ago

Issue validation

Command used

No response

Plugin version

7.0.5

Describe the bug

excalidraw is transformed to svg,bug the link path is not changed

How to reproduce ?

  1. create a file
  2. link a excalidraw file and add share tag 3.publish this file 4.there is a svg file,but the output is still link excalidraw

the source file

image

the output file

image

Minimal Reproducible Example

in how to reproduce

Configuration

{
  "github": {
    "branch": "main",
    "automaticallyMergePR": true,
    "dryRun": {
      "enable": true,
      "folderName": "github-publisher"
    },
    "tokenPath": "%configDir%/plugins/%pluginID%/env",
    "api": {
      "tiersForApi": "Github Free/Pro/Team (default)",
      "hostname": ""
    },
    "workflow": {
      "commitMessage": "[PUBLISHER] Merge",
      "name": ""
    },
    "verifiedRepo": true
  },
  "upload": {
    "behavior": "obsidian",
    "defaultName": "content",
    "rootFolder": "",
    "yamlFolderKey": "",
    "frontmatterTitle": {
      "enable": false,
      "key": "title"
    },
    "replaceTitle": [],
    "replacePath": [],
    "autoclean": {
      "enable": false,
      "excluded": []
    },
    "folderNote": {
      "enable": false,
      "rename": "index.md",
      "addTitle": {
        "enable": false,
        "key": "title"
      }
    },
    "metadataExtractorPath": ""
  },
  "conversion": {
    "hardbreak": false,
    "dataview": true,
    "censorText": [],
    "tags": {
      "inline": false,
      "exclude": [],
      "fields": []
    },
    "links": {
      "internal": false,
      "unshared": false,
      "wiki": false,
      "slugify": "disable"
    }
  },
  "embed": {
    "attachments": true,
    "overrideAttachments": [],
    "keySendFile": [],
    "notes": false,
    "folder": "content/images",
    "convertEmbedToLinks": "keep",
    "charConvert": "->"
  },
  "plugin": {
    "shareKey": "share",
    "excludedFolder": [],
    "copyLink": {
      "enable": false,
      "links": "",
      "removePart": [],
      "transform": {
        "toUri": true,
        "slugify": "lower",
        "applyRegex": []
      }
    },
    "setFrontmatterKey": "Set"
  }
}

Relevant log output

No response

OS

MacOS

Anything else?

No response

Obsidian information

SYSTEM INFO:
    Obsidian version: v1.5.12
    Installer version: v1.5.3
    Operating system: Darwin Kernel Version 23.2.0: Wed Nov 15 21:53:18 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T6000 23.2.0
    Login status: logged in
    Catalyst license: none
    Insider build toggle: off
    Live preview: on
    Base theme: adapt to system
    Community theme: Border v1.7.16
    Snippets enabled: 5
    Restricted mode: off
    Plugins installed: 20
    Plugins enabled: 20
        1: Dataview v0.5.66
        2: Tasks v6.2.0
        3: Templater v2.2.3
        4: LifeOS v1.12.4
        5: Copy Block Link v1.0.4
        6: Fuzzy Chinese Pinyin v2.20.1
        7: Better Search Views v0.2.2
        8: Update time on edit v2.4.0
        9: Weread v0.10.0
        10: QuickAdd v1.8.1
        11: Linter v1.23.2
        12: Commander v0.5.1
        13: Local REST API v2.3.0
        14: Folder Note v0.7.3
        15: Banners v1.3.3
        16: SimpRead Sync v2.1.1
        17: BRAT v1.0.1
        18: Excalidraw v2.1.3
        19: Metacopy v1.9.2
        20: Github Publisher v7.0.5

RECOMMENDATIONS:
    Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
    Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.
Mara-Li commented 6 months ago
 "links": {
      "internal": false,
      "unshared": false,
      "wiki": false,
      "slugify": "disable"
}

You need to enable the different link transformation.

JayClock commented 6 months ago

Thanks!