search

EnviroDIY / Arduino-SDI-12

An Arduino library for SDI-12 communication with a wide variety of environmental sensors. This library provides a general software solution, without requiring any additional hardware.
https://github.com/EnviroDIY/Arduino-SDI-12/wiki
BSD 3-Clause "New" or "Revised" License
164 stars 100 forks source link

Weak Signal Bug Fix #3

Closed Kevin-M-Smith closed 10 years ago

Kevin-M-Smith commented 10 years ago

This pull request modifies the setState function. Since the function did not return immediately from the conditional statements, any invocation of the function would inevitably execute the ELSE statement of the final IF(state==LISTENING) which unnecessarily put the pin into the input state and significantly reduced signal strength. This code has been tested and is ready for merging.

Thanks to Gerard Ista and team for debugging the issue.

Kevin-M-Smith commented 10 years ago

This bug fix actually contained an error because of a invalid library source path during testing. A second pull request has been issued with the proper changes.