search

EnviroDIY / ModularSensors

An Arduino library to give environmental sensors a common interface of functions for use with Arduino-framework dataloggers, such as the EnviroDIY Mayfly.
https://envirodiy.github.io/ModularSensors/
Other
81 stars 48 forks source link

Iss194 reliable delivery batch upload #447

Open neilh10 opened 1 year ago

neilh10 commented 1 year ago

Per description update in #194 basic merge to (develop) describied in ModularSensors\a\mayfly2_wifi_s6b\Readme.md Test module built with PIO Two test modules run over weekend with good test results. Will share data separately in next couple of days. Two test modules built as "alpha" testing from, ModularSensors\a\mayfly1_wifi_wroom ModularSensors\a\mayfly2_wifi_s6b Not tested promoting to examples and building to the branch, but I wouldn't expect in module changes.

My fork has support for the RTC of the SAMD51 which is slightly different than SAMD21 - disentangling this is a bit challenging, so a few misc statements may refer to this.

SRGDamia1 commented 1 year ago

Is there a reason you always use "que" instead of queue? Could you change to queue, especially for function names?

neilh10 commented 1 year ago

labels are a label so long as unique. Though I see what you mean its not very unique . Will work on it. :)

neilh10 commented 1 year ago

I wonder if you managed to compile it and or unit test it. I was hoping to make it easy for it to be at least verified. :)

SRGDamia1 commented 1 year ago

I've compiled it, but I haven't tested it yet.

neilh10 commented 1 year ago

Ok thanks for the info.

SRGDamia1 commented 1 year ago

I'm slowly taking tiny steps working to understand your code. I've been able to test the code and see that it mostly works, but there are a lot of compiler warnings and that I want to have fixed and more things that need to be documented.

neilh10 commented 1 year ago

Hey good to hear. Let me know. The value of using the WiFi is it can be set up to do unit testing for a number of facility "soft" failure cases.

Intrigued as to what tests you've done, and what cases you are trying that aren't working out.?

Though as I mentioned earlier, I did do the PR against my 'development' branch (rel1_dvlp1m) - which maybe was a mistake,
There is a getting to be a fair amount of technical debt round "Managing time" and perhaps EnviroDIY_DS3231 , RTC and Utilites can be part of a Namespace - "using namespace sodaq_DS3231_nm;" My rel1_dvlp1m has the SAMD51/Wio Terminal working on it, but has required fixes to work with the time utilities. For my "master" release1 I haven't merged my rel1_dvlp1m to yet as I've swamped with other issues Since then I do have the esp32-wroom working in my rel1_dvlp1m.

Here is the output of my compile, that was based off (master) for what I did a PR on, I don't see any warnings for the code I submitted

ModularSensors\a\mayfly2_wifi_s6b>       git status
On branch iss194_rel_dvl
Your branch is up to date with 'origin/iss194_rel_dvl'.

nothing to commit, working tree clean

CONFIGURATION: https://docs.platformio.org/page/boards/atmelavr/mayfly.html
PLATFORM: Atmel AVR (4.0.0) > EnviroDIY Mayfly
HARDWARE: ATMEGA1284P 8MHz, 16KB RAM, 127KB Flash
DEBUG: Current (simavr) On-board (simavr)
PACKAGES: 
 - framework-arduino-avr @ 5.1.0 
 - toolchain-atmelavr @ 1.70300.191015 (7.3.0)
LDF: Library Dependency Finder -> https://bit.ly/configure-pio-ldf
LDF Modes: Finder ~ deep+, Compatibility ~ strict
Found 34 compatible libraries
Scanning dependencies...
Dependency Graph
|-- StreamDebugger @ 1.0.1+sha.0da9529
|-- TinyGSM @ 0.11.7+sha.318fa45
|-- SDI-12nh @ 2.1.4-LT5a+sha.1234e7f
|-- EnviroDIY_DS3231 @ 1.3.4
|-- SdFat @ 2.1.2
|-- SPI @ 1.0
|-- EnableInterrupt @ 1.1.0
|-- Wire @ 1.0
|-- PubSubClient @ 2.8.0
|-- Adafruit AM2315 @ 2.2.1
|-- Adafruit BusIO @ 1.11.6
|-- DHT sensor library @ 1.4.4
|-- Adafruit ADS1X15 @ 1.2.0+sha.7d67b45
|-- Adafruit BME280 Library @ 2.2.2
|-- Adafruit Unified Sensor @ 1.1.9
|-- BMP388_DEV @ 1.0.11+sha.2d05a28
|-- Adafruit MPL115A2 @ 2.0.0
|-- KellerModbus @ 0.2.2
|-- SensorModbusMaster @ 0.6.8
|-- DallasTemperature @ 3.9.1
|-- OneWire @ 2.3.7
|-- MS5803 @ 0.1.2
|-- Adafruit SHT4x Library @ 1.0.4
|-- Adafruit INA219 @ 1.2.1
|-- Tally_Library @ 0.1.0+sha.3b128ad
|-- YosemitechModbus @ 0.4.0
Building in release mode
Compiling .pio\src\LoggerBase.cpp.o
Compiling .pio\src\LoggerModem.cpp.o
Compiling .pio\src\SensorBase.cpp.o
Compiling .pio\src\VariableArray.cpp.o
Compiling .pio\src\VariableBase.cpp.o
Compiling .pio\src\WatchDogs\WatchDogAVR.cpp.o
Compiling .pio\src\WatchDogs\WatchDogSAMD.cpp.o
Compiling .pio\src\dataPublisherBase.cpp.o
Compiling .pio\src\modems\DigiXBee.cpp.o
Compiling .pio\src\modems\DigiXBee3GBypass.cpp.o
Compiling .pio\src\modems\DigiXBeeCellularTransparent.cpp.o
Compiling .pio\src\modems\DigiXBeeLTEBypass.cpp.o
Compiling .pio\src\modems\DigiXBeeWifi.cpp.o
Compiling .pio\src\modems\EspressifESP8266.cpp.o
Compiling .pio\src\modems\QuectelBG96.cpp.o
Compiling .pio\src\modems\SIMComSIM7000.cpp.o
Compiling .pio\src\modems\SIMComSIM7080.cpp.o
Compiling .pio\src\modems\SIMComSIM800.cpp.o
D:\usr\a\code\dvlpRelDlvry1\ModularSensors\src\LoggerBase.cpp: In member function 'void Logger::logDataAndPubReliably(uint8_t)':
D:\usr\a\code\dvlpRelDlvry1\ModularSensors\src\LoggerBase.cpp:1674:31: warning: unused variable 'ALL_CANCELLED_pm' [-Wunused-variable]
             const static char ALL_CANCELLED_pm[] EDIY_PROGMEM =
                               ^~~~~~~~~~~~~~~~
D:\usr\a\code\dvlpRelDlvry1\ModularSensors\src\LoggerBase.cpp:1685:35: warning: unused variable 'TX_CANCELLED_pm' [-Wunused-variable]
                 const static char TX_CANCELLED_pm[] EDIY_PROGMEM =
                                   ^~~~~~~~~~~~~~~
Compiling .pio\src\modems\SequansMonarch.cpp.o
Compiling .pio\src\modems\Sodaq2GBeeR6.cpp.o
Compiling .pio\src\modems\SodaqUBeeR410M.cpp.o
Compiling .pio\src\modems\SodaqUBeeU201.cpp.o
Compiling .pio\src\publishers\DreamHostPublisher.cpp.o
Compiling .pio\src\publishers\EnviroDIYPublisher.cpp.o
Compiling .pio\src\publishers\ThingSpeakPublisher.cpp.o
Compiling .pio\src\publishers\UbidotsPublisher.cpp.o
Compiling .pio\src\sensors\AOSongAM2315.cpp.o
Compiling .pio\src\sensors\AOSongDHT.cpp.o
Compiling .pio\src\sensors\AnalogElecConductivity.cpp.o
Compiling .pio\src\sensors\ApogeeSQ212.cpp.o
Compiling .pio\src\sensors\AtlasParent.cpp.o
Compiling .pio\src\sensors\AtlasScientificCO2.cpp.o
Compiling .pio\src\sensors\AtlasScientificDO.cpp.o
Compiling .pio\src\sensors\AtlasScientificEC.cpp.o
Compiling .pio\src\sensors\BoschBME280.cpp.o
Compiling .pio\src\sensors\BoschBMP3xx.cpp.o
Compiling .pio\src\sensors\CampbellOBS3.cpp.o
Compiling .pio\src\sensors\Decagon5TM.cpp.o
Compiling .pio\src\sensors\EverlightALSPT19.cpp.o
Compiling .pio\src\sensors\FreescaleMPL115A2.cpp.o
Compiling .pio\src\sensors\KellerParent.cpp.o
Compiling .pio\src\sensors\MaxBotixSonar.cpp.o
Compiling .pio\src\sensors\MaximDS18.cpp.o
Compiling .pio\src\sensors\MaximDS3231.cpp.o
Compiling .pio\src\sensors\MeaSpecMS5803.cpp.o
Compiling .pio\src\sensors\MeterTeros11.cpp.o
Compiling .pio\src\sensors\PaleoTerraRedox.cpp.o
Compiling .pio\src\sensors\ProcessorStats.cpp.o
Compiling .pio\src\sensors\RainCounterI2C.cpp.o
Compiling .pio\src\sensors\SDI12Sensors.cpp.o
Compiling .pio\src\sensors\SensirionSHT4x.cpp.o
Compiling .pio\src\sensors\TIADS1x15.cpp.o
Compiling .pio\src\sensors\TIINA219.cpp.o
Compiling .pio\src\sensors\TallyCounterI2C.cpp.o
Compiling .pio\src\sensors\TurnerCyclops.cpp.o
Compiling .pio\src\sensors\YosemitechParent.cpp.o
Compiling .pio\build\mayfly\src\mayfly2_wifi_s6b.cpp.o
Compiling .pio\build\mayfly\lib82e\SDI-12nh\SDI12.cpp.o
Compiling .pio\build\mayfly\lib82e\SDI-12nh\SDI12_boards.cpp.o
Compiling .pio\build\mayfly\liba69\Wire\Wire.cpp.o
Compiling .pio\build\mayfly\liba69\Wire\utility\twi.c.o
Compiling .pio\build\mayfly\libff1\EnviroDIY_DS3231\Sodaq_DS3231.cpp.o
Compiling .pio\build\mayfly\lib306\SPI\SPI.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\ExFatLib\ExFatDbg.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\ExFatLib\ExFatFile.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\ExFatLib\ExFatFilePrint.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\ExFatLib\ExFatFileWrite.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\ExFatLib\ExFatFormatter.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\ExFatLib\ExFatName.cpp.o
Archiving .pio\build\mayfly\lib82e\libSDI-12nh.a
Compiling .pio\build\mayfly\lib987\SdFat\ExFatLib\ExFatPartition.cpp.o
Archiving .pio\build\mayfly\lib306\libSPI.a
Archiving .pio\build\mayfly\liba69\libWire.a
Archiving .pio\build\mayfly\libff1\libEnviroDIY_DS3231.a
Compiling .pio\build\mayfly\lib987\SdFat\ExFatLib\ExFatVolume.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\FatLib\FatDbg.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\FatLib\FatFile.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\FatLib\FatFileLFN.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\FatLib\FatFilePrint.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\FatLib\FatFileSFN.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\FatLib\FatFormatter.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\FatLib\FatName.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\FatLib\FatPartition.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\FatLib\FatVolume.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\FreeStack.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\FsLib\FsFile.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\FsLib\FsNew.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\FsLib\FsVolume.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\MinimumSerial.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\SdCard\SdCardInfo.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\SdCard\SdSpiCard.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\SdCard\SdioTeensy.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\SpiDriver\SdSpiArtemis.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\SpiDriver\SdSpiChipSelect.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\SpiDriver\SdSpiDue.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\SpiDriver\SdSpiESP.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\SpiDriver\SdSpiParticle.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\SpiDriver\SdSpiSTM32.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\SpiDriver\SdSpiSTM32Core.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\SpiDriver\SdSpiTeensy3.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\common\FmtNumber.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\common\FsCache.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\common\FsDateTime.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\common\FsName.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\common\FsStructs.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\common\FsUtf.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\common\PrintBasic.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\common\upcase.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\iostream\StdioStream.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\iostream\StreamBaseClass.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\iostream\istream.cpp.o
Compiling .pio\build\mayfly\lib987\SdFat\iostream\ostream.cpp.o
Compiling .pio\build\mayfly\lib766\PubSubClient\PubSubClient.cpp.o
Compiling .pio\build\mayfly\lib66d\Adafruit BusIO\Adafruit_BusIO_Register.cpp.o
Compiling .pio\build\mayfly\lib66d\Adafruit BusIO\Adafruit_I2CDevice.cpp.o
Compiling .pio\build\mayfly\lib66d\Adafruit BusIO\Adafruit_SPIDevice.cpp.o
Compiling .pio\build\mayfly\libf9e\Adafruit AM2315\Adafruit_AM2315.cpp.o
Compiling .pio\build\mayfly\lib9a1\Adafruit Unified Sensor\Adafruit_Sensor.cpp.o
Compiling .pio\build\mayfly\lib703\DHT sensor library\DHT.cpp.o
Compiling .pio\build\mayfly\lib703\DHT sensor library\DHT_U.cpp.o
Compiling .pio\build\mayfly\lib0b9\Adafruit ADS1X15\Adafruit_ADS1015.cpp.o
.pio\libdeps\mayfly\PubSubClient\src\PubSubClient.cpp: In member function 'boolean PubSubClient::publish_P(const char*, const uint8_t*, unsigned int, boolean)':
.pio\libdeps\mayfly\PubSubClient\src\PubSubClient.cpp:523:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     return (rc == expectedLength);
             ~~~^~~~~~~~~~~~~~~~~
.pio\libdeps\mayfly\Adafruit ADS1X15\Adafruit_ADS1015.cpp: In member function 'void Adafruit_ADS1015::startContinuous_SingleEnded(uint8_t)':
.pio\libdeps\mayfly\Adafruit ADS1X15\Adafruit_ADS1015.cpp:490:11: warning: unused variable 'primingRead' [-Wunused-variable]
   int16_t primingRead = readADC_SingleEnded(channel);
           ^~~~~~~~~~~
.pio\libdeps\mayfly\Adafruit ADS1X15\Adafruit_ADS1015.cpp: In member function 'void Adafruit_ADS1015::startContinuous_Differential(adsDiffMux_t)':
.pio\libdeps\mayfly\Adafruit ADS1X15\Adafruit_ADS1015.cpp:529:11: warning: unused variable 'primingRead' [-Wunused-variable]
   int16_t primingRead = readADC_Differential(regConfigDiffMUX);
           ^~~~~~~~~~~
Archiving .pio\build\mayfly\lib703\libDHT sensor library.a
Archiving .pio\build\mayfly\lib9a1\libAdafruit Unified Sensor.a
Archiving .pio\build\mayfly\libf9e\libAdafruit AM2315.a
Archiving .pio\build\mayfly\lib66d\libAdafruit BusIO.a
Compiling .pio\build\mayfly\lib051\Adafruit BME280 Library\Adafruit_BME280.cpp.o
Compiling .pio\build\mayfly\lib3c3\BMP388_DEV\BMP388_DEV.cpp.o
Compiling .pio\build\mayfly\lib3c3\BMP388_DEV\Device.cpp.o
Archiving .pio\build\mayfly\lib766\libPubSubClient.a
Compiling .pio\build\mayfly\libc3c\Adafruit MPL115A2\Adafruit_MPL115A2.cpp.o
Compiling .pio\build\mayfly\lib071\SensorModbusMaster\SensorModbusMaster.cpp.o
Archiving .pio\build\mayfly\lib0b9\libAdafruit ADS1X15.a
Archiving .pio\build\mayfly\lib987\libSdFat.a
Compiling .pio\build\mayfly\lib3be\KellerModbus\KellerModbus.cpp.o
Compiling .pio\build\mayfly\lib9a7\OneWire\OneWire.cpp.o
Compiling .pio\build\mayfly\lib4f0\DallasTemperature\DallasTemperature.cpp.o
Archiving .pio\build\mayfly\lib051\libAdafruit BME280 Library.a
Compiling .pio\build\mayfly\liba28\MS5803\MS5803.cpp.o
Compiling .pio\build\mayfly\lib781\Adafruit SHT4x Library\Adafruit_SHT4x.cpp.o
Compiling .pio\build\mayfly\lib396\Adafruit INA219\Adafruit_INA219.cpp.o
Compiling .pio\build\mayfly\libf98\Tally_Library_I2C\Tally.cpp.o
Compiling .pio\build\mayfly\libf98\Tally_Library_I2C\Tally_I2C.cpp.o
Archiving .pio\build\mayfly\lib3c3\libBMP388_DEV.a
Archiving .pio\build\mayfly\lib071\libSensorModbusMaster.a
Archiving .pio\build\mayfly\libc3c\libAdafruit MPL115A2.a
Archiving .pio\build\mayfly\lib781\libAdafruit SHT4x Library.a
Archiving .pio\build\mayfly\lib4f0\libDallasTemperature.a
Archiving .pio\build\mayfly\lib396\libAdafruit INA219.a
Archiving .pio\build\mayfly\liba28\libMS5803.a
Archiving .pio\build\mayfly\lib9a7\libOneWire.a
Archiving .pio\build\mayfly\lib3be\libKellerModbus.a
Compiling .pio\build\mayfly\lib8e5\YosemitechModbus\YosemitechModbus.cpp.o
Archiving .pio\build\mayfly\libFrameworkArduinoVariant.a
Compiling .pio\build\mayfly\FrameworkArduino\CDC.cpp.o
Compiling .pio\build\mayfly\FrameworkArduino\HardwareSerial.cpp.o
Archiving .pio\build\mayfly\libf98\libTally_Library_I2C.a
Compiling .pio\build\mayfly\FrameworkArduino\HardwareSerial0.cpp.o
Compiling .pio\build\mayfly\FrameworkArduino\HardwareSerial1.cpp.o
Compiling .pio\build\mayfly\FrameworkArduino\HardwareSerial2.cpp.o
Compiling .pio\build\mayfly\FrameworkArduino\HardwareSerial3.cpp.o
Compiling .pio\build\mayfly\FrameworkArduino\IPAddress.cpp.o
Compiling .pio\build\mayfly\FrameworkArduino\PluggableUSB.cpp.o
.pio\libdeps\mayfly\YosemitechModbus\src\YosemitechModbus.cpp: In member function 'byte yosemitech::getSlaveID()':
.pio\libdeps\mayfly\YosemitechModbus\src\YosemitechModbus.cpp:113:9: warning: unused variable 'respSize' [-Wunused-variable]
     int respSize = modbus.sendCommand(command, 8);
         ^~~~~~~~
Compiling .pio\build\mayfly\FrameworkArduino\Print.cpp.o
Compiling .pio\build\mayfly\FrameworkArduino\Stream.cpp.o
Compiling .pio\build\mayfly\FrameworkArduino\Tone.cpp.o
Compiling .pio\build\mayfly\FrameworkArduino\USBCore.cpp.o
Compiling .pio\build\mayfly\FrameworkArduino\WInterrupts.c.o
Compiling .pio\build\mayfly\FrameworkArduino\WMath.cpp.o
Archiving .pio\build\mayfly\lib8e5\libYosemitechModbus.a
Compiling .pio\build\mayfly\FrameworkArduino\WString.cpp.o
Compiling .pio\build\mayfly\FrameworkArduino\abi.cpp.o
Compiling .pio\build\mayfly\FrameworkArduino\hooks.c.o
Compiling .pio\build\mayfly\FrameworkArduino\main.cpp.o
Compiling .pio\build\mayfly\FrameworkArduino\new.cpp.o
Compiling .pio\build\mayfly\FrameworkArduino\wiring.c.o
Compiling .pio\build\mayfly\FrameworkArduino\wiring_analog.c.o
Compiling .pio\build\mayfly\FrameworkArduino\wiring_digital.c.o
Compiling .pio\build\mayfly\FrameworkArduino\wiring_pulse.S.o
Compiling .pio\build\mayfly\FrameworkArduino\wiring_pulse.c.o
Compiling .pio\build\mayfly\FrameworkArduino\wiring_shift.c.o
Archiving .pio\build\mayfly\libFrameworkArduino.a
Linking .pio\build\mayfly\firmware.elf
.pio\libdeps\mayfly\TinyGSM@src-e5c1fb991ba78dd1196bb61491ea9ee9\src/TinyGsmClientUBLOX.h:37:6: warning: type 'RegStatus' violates the C++ One Definition Rule [-Wodr]
 enum RegStatus {
      ^
.pio\libdeps\mayfly\TinyGSM@src-e5c1fb991ba78dd1196bb61491ea9ee9\src/TinyGsmClientXBee.h:51:6: note: an enum with different value name is defined in another translation unit
 enum RegStatus {
      ^
Checking size .pio\build\mayfly\firmware.elf
Advanced Memory Usage is available via "PlatformIO Home > Project Inspect"
RAM:   [===       ]  30.4% (used 4986 bytes from 16384 bytes)
Flash: [=======   ]  68.5% (used 89122 bytes from 130048 bytes)
Building .pio\build\mayfly\firmware.hex
SRGDamia1 commented 1 year ago

Processing mayfly (board: mayfly; platform: atmelavr; framework: arduino)

Verbose mode can be enabled via -v, --verbose option CONFIGURATION: https://docs.platformio.org/page/boards/atmelavr/mayfly.html PLATFORM: Atmel AVR (4.2.0) > EnviroDIY Mayfly HARDWARE: ATMEGA1284P 8MHz, 16KB RAM, 127KB Flash DEBUG: Current (simavr) External (simavr) PACKAGES:

Environment Status Duration

mayfly SUCCESS 00:02:59.516

neilh10 commented 1 year ago

weeelll fantastic - I supplied a version !!... you've modified it, done some testing - and these are pretty easy fixes above if that's your comments.

Wells its funny , just been part of capstone engineering project for final year engineers - part of this process is to bring out the "technical conversation " the value for specifications, technical requirements and then testing to them.

So to recap, I defined the context of the submission , described the algorithms and I believe it was agreed to
https://github.com/EnviroDIY/ModularSensors/issues/194#issuecomment-1629331122

neilh10 commented 1 year ago

If you publish your test framework happy to look at your changes :)

SRGDamia1 commented 1 year ago

@neilh10. I'm sorry; I didn't intend to push directly to your branch. I'll try to fix the git.

neilh10 commented 1 year ago

Ok I've been away. It looks to me like you put all the changes on a branch (reliable_delivery). Sorry its taking you so much work.
IMHO to be able to take in in PRs, and distribute the work, (and response ability) its more viable to drive the PR acceptance by test results. This type of software is very testing intensive, and in a team environment with a number of submitters, I've seen it work to define a test environment and then to use the results from the test environment to define acceptance on to (develop) After the functionality that is working - that is seen from the outside is good - then enter a phase of refactoring that does the cosmetic changes to keep it uniform . Just my 2cents.

BTW a test run that I did last weekend with my production software and over SIM7080G and ATT (through dataplans.digikey), had good success - which is verifying my fork of the the SIMComSIM7080 and SIM7080G/57600K and the MMW response. https://github.com/ODM2/ODM2DataSharingPortal/issues/673#issuecomment-1714231187 I'm having an issue with ModemMacros.h with SIMComSIm7080 that I've had to update that is painful, as for software reliability I'm building it as a compile option with DigiXbeeCellularTransparent DigiXbeeWiFi and EsperessESP8266. Pretty amazing that most of what happens with ModemMacros.h seems to work ~ I don't try and follow it, providing it sends out the right AT cmds. Which is my attempt to survive software complexity through a Test Driven approach. Define the tests and edge conditions, then characterize it running the tests and if they are in bounds "bless it" !!

neilh10 commented 11 months ago

Just wondering if any visibility on this merge. Related https://github.com/EnviroDIY/ModularSensors/issues/194