search

EnviroDIY / YosemitechModbus

A library to use an Arduino as a master to control and communicate with the modbus sensors produced by Yosemitech. Depends on the EnviroDIY/SensorModbusMaster library.
Other
10 stars 7 forks source link

V4.0 specified in ModularSensors but not released #32

Closed neilh10 closed 1 year ago

neilh10 commented 1 year ago

For enviroDIY/ModularSensors (develop) library.json specifies "name": "YosemitechModbus", "owner": "envirodiy", "library id": "2078", "url": "https://github.com/EnviroDIY/YosemitechModbus", "version": "~0.4.0",

When trying to build I get Library Manager: Installing envirodiy/YosemitechModbus @ ~0.4.0 Library Manager: Warning! Could not install {'name': 'YosemitechModbus', 'owner': 'envirodiy', 'library id': '2078', 'url': 'https://github.com/EnviroDIY/YosemitechModbus', 'version': '~0.4.0', 'note': 'Arduino library for communication with Yosemitech sensors via Modbus.', 'authors': ['Sara Damiano', 'Anthony Aufdenkampe'], 'frameworks': ['arduino'], 'platforms': ['atmelavr', 'atmelsam']} dependency for theEnviroDIY_ModularSensors package

as EnviroDIY/YosemitechModbus (master) doesn't have a 0.4.0
and needs referencing to (develop) for it to work

Library Manager: Installing git+https://github.com/EnviroDIY/YosemitechModbus#develop

neilh10 commented 1 year ago

Others having a similar issue https://www.envirodiy.org/topic/yosemite-library-cant-be-find/#post-17555

aufdenkampe commented 1 year ago

@neilh10, thanks for posting this issue!

I had been waiting merge in v0.4 here:

Until after @SRGDamia1 to issued a new release of Modular sensors with this Pull Request:

In hindsight, my work on YosemitechModbus v0.4 was designed to be backwards compatible, so I'll move forward with PR #31.

aufdenkampe commented 1 year ago

@neilh10, I just merged PR #31 and issued a release.

PlatformIO's Library Registry should auto-update in the next day or so. See: https://registry.platformio.org/libraries/envirodiy/YosemitechModbus

Once it shows v0.4.0, your problem should be fixed. Let me know.

neilh10 commented 1 year ago

thanks for the update - will try it.

From past projects being clear how code is promoted takes a bit of thinking about, and there needs to be sand box to play around in. Hard to get it perfect straight away.

I think of (develop) https://github.com/EnviroDIY/ModularSensors/tree/develop as being where everything is worked on, prototyped, so slightly risky.

So that was the case in just finding that as EnviroDIY/YosemitechModbus (master) doesn't have a 0.4.0 and needs referencing to EnviroDIY/YosemitechModbus (develop) for it to work

I typically try and merge from EnviroDIY/ModularSensors (master) to my development branch neilh10/ModularSensors (rel1_dvlp1m) and then test there. However in this case, because there was a lot on EnviroDIY/ModularSensors (develop), so I pulled in the updates onto my development branch neilh10/ModularSensors (rel1_dvlp1m), and the lib reference broke it, but was easy to work around.

Many thanks

neilh10 commented 1 year ago

Testing in my environment - works to pull from https://github.com/EnviroDIY/YosemitechModbus