search

EnviroMine / EnviroMine-1.7

Other
44 stars 37 forks source link

Statuses don't reset on death #107

Open Yoghurt4C opened 9 years ago

Yoghurt4C commented 9 years ago

Statuses don't reset with "keep statuses on death = false" in SMP and people keep dying after respawning

Neofluttx commented 9 years ago

I can confirm this, they don't reset

Funwayguy commented 9 years ago

Still can't reproduce this in single player or on a server

InquisitorCM commented 9 years ago

I have same problem. In singleplayer everything works well.

oaksvirals commented 9 years ago

I'm having this issue as well. I'm working on a modpack for the OhGaming community and the stats stay through death.

glixyl commented 9 years ago

I can confirm this happening on Cauldron even with no plugins installed and the config for "keep status on death" = false, but not in single player or on a non-Cauldron.

HiTECNOLOGYs commented 9 years ago

Can confirm this. Cauldron does break this feature with latest EnviroMine.

thislooksfun commented 9 years ago

That would explain why we can't replicate it...

HiTECNOLOGYs commented 9 years ago

Should we expect a fix or I can start worrying?

thislooksfun commented 9 years ago

Unfortunately, there probably won't be a fix for 1.7. We are in the process of rewriting the mod from the ground up, so hopefully that will include a fix. I have never developed for Cauldron, so I don't know where to start, but if we figure it out, we'll push a patch.

HiTECNOLOGYs commented 9 years ago

I see. Anyway, thanks for such a quick response and great mod.

thislooksfun commented 9 years ago

After a quick google, it seems that Cauldron has been discontinued in favor of Sponge. Could you check to see if the problem occurs on Sponge too?

Funwayguy commented 9 years ago

I could try and fix this (I have tried about 3 times before) but Cauldron has been somewhat an issue to deal with because it removes a lot of Forge hooks that EnviroMine requires to function properly such as one which allows the picking up of dirty/salty water bottles properly.

glixyl commented 9 years ago

thislooksfun: Sponge isn't in a production ready state yet and only supports 1.8, so it is not a viable option for server environments. Funwayguy: To tell the truth, I think that you are very close. The only issue I am aware of that breaks server play is the lack of resetting cold/hot status on death. Cauldron is the only viable solution for hosting many players at once and Enviromine is a very popular mod and to do that we need to use Enviromine 1.2.28 to not have serious bugs. (here i will lobby again to see if it isn't possible to fix the Cauldron issue, perhaps try to fix the Camel pack from 1.2.28?)

Thank you for any consideration.

TwentyOneZ commented 9 years ago

I just created a quick patch mod to make this work as intended with Cauldron until it is fixed. You can download it here: http://www.mediafire.com/download/hnv01vlcvcnnh3b/envirofix-1.0.jar . You can change the value stats are set after dying in the config file. The source code is in my GitHub ( http://github.com/TwentyOneZ/envirofix ).

Funwayguy commented 9 years ago

@TwentyOneZ didn't think that would work but seeing as the events called are the more standard ones I see why not. Thanks for helping with that. In case you're curious, there is source code for the new tracking system here which should theoretically work better than the existing tracking system: https://github.com/EnviroMine/EnviroMine-1.7/blob/teardown/src/main/java/enviromine/core/api/properties/PropertyTracker.java