search

EnviroMine / EnviroMine-1.7

Other
44 stars 38 forks source link

Water bottles don't restore hydration #211

Open axlegear opened 8 years ago

axlegear commented 8 years ago

Cooking dirty water bottles to clean, they do nothing.

PitchBright commented 8 years ago

Please try to describe the issue more clearly. You're not offering up very much information or detail.

axlegear commented 8 years ago

If you fill empty bottles with dirty water, then cook them in a furnace, it makes water bottles. These water bottles do not restore any hydration/thirst or affect temperature or anything. They do nothing. Can't think of any way to more clearly describe that they don't have any effect.

PitchBright commented 8 years ago

Okay... your title was "Water bottles don't restore hydration" (which I understood to mean Water Bottles aren't hydrating the player.)

Then you describe the problem completely differently by saying that something that sounded like you couldn't cook dirty water bottles into clean.

PitchBright commented 8 years ago

Are you saying that Clean Water bottles collected from a water source work (hydrate the player)... but that Clean Water bottles cooked from Dirty Water bottles don't work?

axlegear commented 8 years ago

The last one.. "but that Clean Water bottles cooked from Dirty Water bottles don't work?"

PitchBright commented 8 years ago

(It wasn't an either/or question.)

So clean water collected from a lake works then?

axlegear commented 8 years ago

Yes, only cooked water is broken.

Sorry if I am hard to understand.

PitchBright commented 8 years ago

See if you can figure out what the difference is between Clean Water Bottle (collected from lake) and Clean Water Bottle (made from cooking Dirty Water in Furance) is. That will go a long way in helping you figure out if you found a bug with the mod.

axlegear commented 8 years ago

I would not know how to do this. I am not a modder or dev or programmer.

PitchBright commented 8 years ago

If you are using NEI, or some other type of "more info" tool/mod... you can hover over items and see more information about them (name, id#, etc).

Gather some clean water from a lake. See the info on it. Make some clean water from furnace. See the info on it.

Report back here with your findings :)

axlegear commented 8 years ago

image The above is dirty water cooked

image This is from fresh water

axlegear commented 8 years ago

The fresh water worked fine but the dirty water I cooked doesn't

PitchBright commented 8 years ago

Bizarre. They look identical. I can't imagine why one would work, and the other wouldn't.

axlegear commented 8 years ago

NBT data? No idea, there must be some unviewable attached info

PitchBright commented 8 years ago

I'm thinkin' the same thing as you.

PitchBright commented 8 years ago

When you have the clean lake water in your hotbar... and you shift click on the clean water in the furnace output slot... does it stack into the clean lake water in your hotbar?

Edit: Will they stack together at all, I guess.

axlegear commented 8 years ago

no

PitchBright commented 8 years ago

Yeah, something might be wrong then. Leave this issue open for now.

axlegear commented 8 years ago

Oho! Interesting fix. Someone noted it works on singleplayer but not the server. I checked and the server doesn't generate any configs under minecraft\config\enviromine\profiles\default\CustomProperties but SP does

So I copied the SP configs to the server, and now it all works It seems this file has something relevent:

enviromine.txt

axlegear commented 8 years ago

So if anyone else has this issue, the above is a workaround fix Tho still a bug with the mod not generating proper configs for server so that needs fixing

PitchBright commented 8 years ago

Awesome detective work, @axlegear !

That also explains why I never had any of these issues. I generated my configs in SP, and then moved them all to the server, when I was ready to run the server with EM.

axlegear commented 8 years ago

Hopefully at least it will help the modders find and fix the issue. Prolly pretty simple