EnviroMine / EnviroMine-1.7

Other
44 stars 38 forks source link

Custom Stability disabling physics isn't the same as profile disable physics #216

Open xarses opened 8 years ago

xarses commented 8 years ago

After trying to come up with custom profile to work around the problems in #214 I've found that there appears to be a difference between physics disable on a stability type, and that provided by the profile / global disable. It occurs when the block in question already behaves like a vanilla sand-type, in that un-supported it falls straight down.

When these types are encountered some portion of the code path isn't disabled as can be seen with GregTech soft ores (sand, gravel, broken) as they loose their nbt data regardless of the config on stability, but retain it when it's turned off for all blocks via profile level settings.

stability {
    ore {
        B:"01.Enable Physics"=false
        I:"02.Max Support Distance"=1
        I:"03.Min Missing Blocks To Fall"=0
        I:"04.Max Missing Blocks To Fall"=0
        B:"05.Can Hang"=true
        B:"06.Holds Others Up"=true
    }
}
block {
    tile_gtmeta_ore_normal_sand {
        S:01.Name=gregtech:gt.meta.ore.normal.sand
        I:02.MetaID=-1
        S:03.DropName=
        I:04.DropMetaID=-1
        I:05.DropNumber=-1
        B:"06.Enable Temperature"=false
        D:07.Temperature=0.0
        D:"08.Air Quality"=1.0
        D:09.Sanity=0.0
        S:10.Stability=ore
        B:11.Slides=false
        B:"12.Slides When Wet"=false
    }
}

video results: https://youtu.be/czLEWnME-gI

axlegear commented 8 years ago

Confirmed. Attempts at custom settings have been utterly ignored, resulting in a major conflict between enviromine and mods whose gravel/sand/etc. blocks contain NBTs and TEs.

GenDeathrow commented 8 years ago

Enviromine hasn't been updated in some time. We moved on to other projects. Now this issue has never been reported before. And we do store nbt data, when we trigger a physics drop.You can check the physics block code. Now we could be having an issue were we copy the block and they overwrite causing data to be Lost. But just a theroy.

axlegear commented 8 years ago

Does that mean Enviromine is abandoned?