Closed lechup closed 7 years ago
This PR is based on #12, so be warned ;)
Do we should bother about NODE_ENV=production ? Tests are not able to run in this mode because of devDependencies vs dependencies in package.json
NODE_ENV=production
I've also added docker-compose build check, but it takes around 2 minutes more to run. What do You think?
docker-compose build
Details are here: https://travis-ci.org/EnviroMonitor/EnviroMonitorFrontend/builds#
This change is
Looks good to me :).
Reviewed 30 of 30 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
This PR is based on #12, so be warned ;)
Do we should bother about
NODE_ENV=production
? Tests are not able to run in this mode because of devDependencies vs dependencies in package.jsonI've also added
docker-compose build
check, but it takes around 2 minutes more to run. What do You think?Details are here: https://travis-ci.org/EnviroMonitor/EnviroMonitorFrontend/builds#
This change is