EnvironmentOntology / envo

A community-driven ontology for the representation of environments
http://www.environmentontology.org
Creative Commons Zero v1.0 Universal
132 stars 51 forks source link

NTR: human dwelling environment related terms #1008

Open zhengj2007 opened 4 years ago

zhengj2007 commented 4 years ago

VEuPathDB database (https://veupathdb.org/) and CINECA project (https://www.cineca-project.eu) need few terms related to human dwelling environment. We think the terms may fit in EnVO domain. Here are proposed labels, definitions, parent and other annotation information.

Name Value
Label environment associated with human dwelling
Definition Environmental system associated with the dwelling used by humans.
Definition source Penn Group
Parent ENVO_01000254 environmental system
Name Value
Label human dwelling environment
Definition An environment associated with human dwelling that constitutes a human's immediate residence.
Parent environment associated with human dwelling
Name Value
Label human neighborhood environment
Definition An environment associated with human dwelling that constitutes the immediate social and/or geographical region in which a human resides.
Parent environment associated with human dwelling
Name Value
Label human workplace environment
Definition An environment associated with human dwelling that constitutes the physical location in which a human works.
Parent environment associated with human dwelling

Related issue: https://github.com/VEuPathDB-ontology/VEuPathDB-ontology/issues/84

beckyjackson commented 4 years ago

Hi @pbuttigieg - I'd like to follow up on this request and see if this is something within the scope of EnVO? We'd like to get these terms in GECKO as soon as possible.

Thanks!

beckyjackson commented 3 years ago

Hi again @pbuttigieg - I was hoping we could still get these terms into EnVO. We have been waiting on these to make our first GECKO release, but we are on a bit of a time crunch now. If we can't get EnVO IDs for these terms in the next week, we plan to add them to GECKO for now. We can deprecate them later if you still decide to add them. Thanks!

cmungall commented 3 years ago

These look like shadow terms for to-be-added terms for neighborhood, dwelling, etc

My strong preference is to only add the concrete terms: dwelling, etc

However, if you truly need the X environment terms then I think these should be explicitly shadows and should follow the yaml for determined environments

@zhengj2007 @beckyjackson how would you feel about making a PR?

beckyjackson commented 3 years ago

Could you point me to those terms? Is it like the one from #264?

For GECKO, we really need the entire environment in which a human / humans live and work (the top level term in this PR). We're calling this "physical environment" in our mappings, but I think this label is too broad for EnVO. I think this is slightly different than just neighborhood and dwellings (the actual structures). This is to refer to, for example, the environment in which a human can be exposed to carcinogens (whether at work or at home - it doesn't necessarily need to be in a structure).

cmungall commented 3 years ago

I had thoughts on 'environment', put them here #1051

OK, for your environment terms, I still think we need the determinants of the environment: neighborhood, dwelling. If these don't exist would you be OK putting these in? Then the DP is X-env = env & determined-by some X

beckyjackson commented 3 years ago

That makes sense to me, and I'd be happy to set up a PR for this.

I think the top level term might need to be reworded. Potentially "environment associated with human activity"? Right now it only lines up the the dwelling environment.

For the child terms (where 'determined by' is RO:0002507)

Which means we also need to add:

I'm not exactly sure where "human workplace" and "neighborhood" belong or if they are even the correct terms to use. A workplace could be a constructed feature, but your workplace could also be outside. It could also be your home. I think of the workplace as more of an environment anyway, so I'm not sure what the determinant of that is. Same goes for neighborhood. Is that a "constructed feature"?