search

EnvironmentOntology / envo

A community-driven ontology for the representation of environments
http://www.environmentontology.org
Creative Commons Zero v1.0 Universal
132 stars 51 forks source link

Deprecate ENVO:alga replaced by PCO:alga excluding Cyanobacteria? #1046

Open kaiiam opened 3 years ago

kaiiam commented 3 years ago

@ramonawalls in https://github.com/PopulationAndCommunityOntology/pco/issues/58 created the new term: alga excluding Cyanobacteria to replace envo: alga. Also xref https://github.com/EcologicalSemantics/ecocore/issues/100.

Unless @pbuttigieg has any objections, should we precede to deprecate and replace by?

cmungall commented 3 years ago

I don't think this belongs in either

kaiiam commented 3 years ago

@cmungall should this be in COB instead?

cmungall commented 3 years ago

no, it's not upper level.

In GO we mint a taxon_union namespace which is terrible as it doesn't resolve

we need a new namespace and sync this with ncbitaxon releases and use the go union patterns

kaiiam commented 3 years ago

I'd be interested in trying to help with this effort @cmungall can you direct me to these go union patterns?

cmungall commented 3 years ago

https://github.com/obophenotype/ncbitaxon/issues/45

cmungall commented 3 years ago

anyway, deprecate in envo and close this for now

kaiiam commented 3 years ago

@cmungall perhaps we can deprecate in ENVO once we have something to replace it by. I'd prefer not to leave downstream projects without a term in the interim.

pbuttigieg commented 3 years ago

@kaiiam agreed, also agreed it's a strange one.

Let's deprecate and add replaced by as you suggested. If there's downstream work to do in deprecating those, it can happen in PCO/ECOCORE

kaiiam commented 3 years ago

Following @pbuttigieg's suggestion for now will be possible once PCO has made it's next release @ramonawalls please let me know when you do so, such that I can import it here.