search

EnvironmentOntology / envo

A community-driven ontology for the representation of environments
http://www.environmentontology.org
Creative Commons Zero v1.0 Universal
130 stars 52 forks source link

manufactured product parent terms #1063

Open kaiiam opened 3 years ago

kaiiam commented 3 years ago

Following on from the discussion in https://github.com/EnvironmentOntology/envo/pull/1060 @matentzn will need some suggestions for parent classes for the following terms.

dye India ink fountain pen ink varnish vitreous enamel turpentine naphtha automatic transmission fluid hydraulic fluid motor oil

kaiiam commented 3 years ago

@pbuttigieg if you have time to suggest what parents for these could be, I can also take a first pass at it.

kaiiam commented 3 years ago

@pbuttigieg @laurenechan @matentzn Following up on the work from #1060, we now have this shared google template which will follow ENVO's new ENVO-Robot-template-and-merge-workflow.

I've documented in some google drive comments how we can update the definitions to follow ENVO's conventions (see here)

Unfortunately ATM, ENVO’s manufactured product hierarchy is a bit underdeveloped so we might be missing some of the needed parent terms for some of these. E.g. we’re missing items like a general paste (for wallpaper paste), coloring agent, ink etc. I propose we can define and add these within this sheet and PR.

kaiiam commented 3 years ago

@matentzn and I just worked on the template together, we've fixed up to the best of our abilities. @pbuttigieg see the PR https://github.com/EnvironmentOntology/envo/pull/1064.

@matentzn regarding https://github.com/EnvironmentOntology/envo/pull/1064 remember not to commit any files other than envo-edit.owl i.e. remove changes to the other 3.

pbuttigieg commented 3 years ago

Most of the examples above should be asserted in the materials hierarchy, and reasoned into the manufactured product hierarchy.

Unfortunately ATM, ENVO’s manufactured product hierarchy is a bit underdeveloped so we might be missing some of the needed parent terms for some of these. E.g. we’re missing items like a general paste (for wallpaper paste), coloring agent, ink etc. I propose we can define and add these within this sheet and PR.

Yes, please do add sensible sub-hierarchies and superclasses - but try to focus on the metaphysics for the asserted axioms. Things like "dye" are role-defined - the actual stuff should likely be elsewhere.

matentzn commented 3 years ago

All of them are now in the materials hierarchy! We just didn't added one more intermediate classes.. I think it should all be in order now, or am I mistaken?

matentzn commented 3 years ago

If you have any better suggestions for the ME hierarchy, feel free to drop them in here: https://docs.google.com/spreadsheets/d/1B1hQHU5RtVLCETuDJtA2OP1rm6VEAXjdUdqXumgrdLY/edit?usp=sharing

Thanks!

kaiiam commented 3 years ago

@pbuttigieg the only intermediate we added was ink. I've added some more commits to fix up the definitions in protege in the owl file on the PR), and updated the template in case we run it again. It's looking good to me, but @pbuttigieg please feel to modify the template or branch for this PR if you think it's missing anything.

pbuttigieg commented 3 years ago

All of them are now in the materials hierarchy! We just didn't added one more intermediate classes.. I think it should all be in order now, or am I mistaken?

Sorry, should have been more precise: the environmental material hierarchy. The definitions also need some more refinement, and I'm not sure about some of the axioms.

If you have any better suggestions for the ME hierarchy, feel free to drop them in here: https://docs.google.com/spreadsheets/d/1B1hQHU5RtVLCETuDJtA2OP1rm6VEAXjdUdqXumgrdLY/edit?usp=sharing

I can review PRs, but I can't commit to doing the actual work of other projects I'm not involved in / don't know about.

@kaiiam See my review on the PR.

kaiiam commented 3 years ago

I can review PRs, but I can't commit to doing the actual work of other projects I'm not involved in / don't know about.

Fair enough I'm also not in anyway involved in this project just trying to keep things moving in terms of ENVO dev.

@kaiiam See my review on the PR.

Yes good points in the review I concede to most of of it, except the part about using CHEBI roles

is there no CHEBI role for colourant? That would help us with inks, dyes, etc.

Unfortunately there are some issues with CHEBI's role classes hence why @cmungall made the CHEBI Integrated Role Ontology, which I think integrating into ENVO might be more complicated then whats desired here.

Since these are @laurenechan's requests and relevant to her work/projects I propose that she be the one to pick this and follow through with as much of @pbuttigieg's feedback as possible.

@laurenechan you have this shared google template which @matentzn and I have started, along with the ENVO-Robot-template-and-merge-workflow which explains how to prepare terms as well as how to compile the robot template. I think between these docs, @pbuttigieg 's comments and the mostly filled out template you should be able to get started on solving the issues @pbuttigieg noted. You can always ask us specific questions if/when you need help along the way.

Let me know if this sounds reasonable to everyone.

pbuttigieg commented 3 years ago

@matentzn @kaiiam

Overall, most of these should be in the environmental material hierarchy (under a phase grouping if possible). Adding the 'output of' some 'manufacturing process' axiom will reason these into the manufactured product hierarchy. Definitions must be changed to match the genus/differentia A is a B which Cs