EnvironmentOntology / envo

A community-driven ontology for the representation of environments
http://www.environmentontology.org
Creative Commons Zero v1.0 Universal
132 stars 51 forks source link

Change classification of island and archipelago to be directly under ABP #1257

Open cmungall opened 2 years ago

cmungall commented 2 years ago

Archipelago

Archipelago is classified as fluid ABP

I find this, and the classification of other Fluid ABPs unusual:

image

For sure, if the archipelago is composed of both the island masses and the water in between then it strictly satisfies the existing textual definition

But is such a classification useful?

The current definition emphasizes the land mass A group of geographically or geologically associated islands

I would be curious to see geographer's opinions on the classification of archipelagos as fluid

Island

I had expected to see island under ABP alongside other geographic features

however, it is in a different branch, under the more abstract "layer" branch, under "planetary landmass":

image

There are only two planetary landmasses: island and thermokast - is that intentional? what about continental landmasses (are these islands?)

Proposal

  1. Move both island and ABP to be directly under ABP
  2. Review phase-axes of ABP subclasses - provide objective criteria for classification under fluid/compound/solid

See also

kaiiam commented 2 years ago

Move both island and ABP to be directly under ABP

I totally agree and think this is an easy fix.

Review phase-axes of ABP subclasses - provide objective criteria for classification under fluid/compound/solid

This requires much more discussion and thought and is probably a whole other thread.

I vote we do a quick fix on the former and leave the latter for the future.