Closed smithGit closed 2 years ago
Thanks @smithGit for the feedback. I believe the use of the word public is intentional in this class as to differentiate it from private or other non-governmental prison facilities. We don't have a term for the latter but it can be requested if needed. See hierarchy here:
Cheers, Kai
Misspelling issue in the label still stands
prision
show be fixed.
Request that the term "public prision" be corrected to "prison" and, as it seems unnecessary, remove the adjective "public."
There are privately operated prisons, so there is a distinction. We can create a more generic prison class and determine a more reasoner-driven way to populate "public" and "private" hierarchies.
Thank you but note my main observation is the misspelling of prison – as prision. (I was not aware of private prisons so no problem with the word “public”.) The ontology is very good but when and if it is updated, it would be nice to correct the spelling. I appreciate your follow-up. Best regards, Sam Smith
From: Pier Luigi Buttigieg @.> Sent: Tuesday, August 9, 2022 11:01 AM To: EnvironmentOntology/envo @.> Cc: Sam Smith @.>; Mention @.> Subject: Re: [EnvironmentOntology/envo] Misspelling of Prison (Issue #1317)
Request that the term "public prision" be corrected to "prison" and, as it seems unnecessary, remove the adjective "public."
There are privately operated prisons, so there is a distinction. We can create a more generic prison class and determine a more reasoner-driven way to populate "public" and "private" hierarchies.
— Reply to this email directly, view it on GitHub https://github.com/EnvironmentOntology/envo/issues/1317#issuecomment-1209497530 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ2PKG4BCYX7WEJRCCHHYTVYJXCBANCNFSM5XGZUSHA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABQ2PKDFH56KTA3W2TEONZLVYJXCBA5CNFSM5XGZUSHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJALXPOQ.gif Message ID: @. @.> >
Thank you @smithGit
The next release will resolve this like so:
Very cool! Did I mention that we are proposing the use of the environment ontology in our plans for an occupation ontology? Environment would show up as a property of where one’s occupation occurs, either as a property of the occupation, such as a forester, or as a property of the “occupation holder,” such as park ranger who works in a forest rather than a desert.
Thanks, Sam
From: Pier Luigi Buttigieg @.> Sent: Wednesday, August 10, 2022 1:06 PM To: EnvironmentOntology/envo @.> Cc: Sam Smith @.>; Mention @.> Subject: Re: [EnvironmentOntology/envo] Misspelling of Prison (Issue #1317)
Thank you @smithGit https://github.com/smithGit
The next release will resolve this like so:
https://user-images.githubusercontent.com/2276146/183973683-c4455117-4908-44a7-bbe4-e4076dd0b8bc.png
— Reply to this email directly, view it on GitHub https://github.com/EnvironmentOntology/envo/issues/1317#issuecomment-1211003364 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ2PKD54L5TQGZUTN4VLJ3VYPOP5ANCNFSM5XGZUSHA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABQ2PKC6LQVYBVHZQMQCQ5LVYPOP5A5CNFSM5XGZUSHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJAXHDZA.gif Message ID: @. @.> >
Looks good @pbuttigieg I presume this is now sorted. I'll add the closeable label would you prefer to close it now or after the next release?
Thanks, Kai. Consider it closed as far as I am concerned, but I am certainly not a principal. Very good ontology, it seems to me! Sam in Michigan
From: Kai Blumberg @.> Sent: Wednesday, August 10, 2022 2:50 PM To: EnvironmentOntology/envo @.> Cc: Sam Smith @.>; Mention @.> Subject: Re: [EnvironmentOntology/envo] Misspelling of Prison (Issue #1317)
Looks good @pbuttigieg https://github.com/pbuttigieg I presume this is now sorted. I'll add the closeable label would you prefer to close it now or after the next release?
— Reply to this email directly, view it on GitHub https://github.com/EnvironmentOntology/envo/issues/1317#issuecomment-1211124175 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ2PKE6SAYGWMTZJWXFGWDVYP2TVANCNFSM5XGZUSHA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABQ2PKCDTGYKS6UJ52C55B3VYP2TVA5CNFSM5XGZUSHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJAYETTY.gif Message ID: @. @.> >
I think we can close if it's merged into master @kaiiam
Keeping issues open until release is too cluttery.
PS many thanks for the background @smithGit - happy to add new content as you need it
Keeping issues open until release is too cluttery.
I completely agree
@smithGit please feel free to consult the ENVO-Robot-template-and-merge-workflow docs if every you want to prepare a batch of terms for inclusion into ENVO.
Agreed. would go further and remove public building as a grouping class. Better to represent publicly accessible as a property. And the placement of prison here is.. odd
On Sat, May 28, 2022 at 8:44 AM Sam Smith @.***> wrote:
Request that the term "public prision" be corrected to "prison" and, as it seems unnecessary, remove the adjective "public." Thanks - Sam Smith - working with U of Michigan Medical Research Center (We will be referencing this ontology for a paper on Occupation Ontology.)
— Reply to this email directly, view it on GitHub https://github.com/EnvironmentOntology/envo/issues/1317, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMMOOVY647ICK4LJYISJLVMI5L7ANCNFSM5XGZUSHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
@smithGit Thanks for catching the misspelling. In regards "public", are some prisons privately run?
indeed, but I don't think ENVO should get into making subtypes of physical buildings based on these critera
On Tue, Oct 11, 2022 at 5:58 AM Bill Duncan @.***> wrote:
@smithGit https://github.com/smithGit Thanks for catching the misspelling. In regards "public", are some prisons privately run?
— Reply to this email directly, view it on GitHub https://github.com/EnvironmentOntology/envo/issues/1317#issuecomment-1274649246, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMMOMQPUZJVVEGJ4TW643WCVP7FANCNFSM5XGZUSHA . You are receiving this because you commented.Message ID: @.***>
Bill – Great to hear from you. I have no opinion on private prisons, but they do exist and come under criticism from some groups:
“Since 2000, the number of people housed in private prisons has increased 14%. Harmful crime policies of the 1980s and beyond fueled a rapid expansion in the nation's prison population. The resulting burden on the public sector led to the modern emergence of for-profit prisons in many states …”
Sentencingproject.org
From: Bill Duncan @.> Sent: Tuesday, October 11, 2022 8:58 AM To: EnvironmentOntology/envo @.> Cc: Sam Smith @.>; Mention @.> Subject: Re: [EnvironmentOntology/envo] Misspelling of Prison (Issue #1317)
@smithGit https://github.com/smithGit Thanks for catching the misspelling. In regards "public", are some prisons privately run?
— Reply to this email directly, view it on GitHub https://github.com/EnvironmentOntology/envo/issues/1317#issuecomment-1274649246 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ2PKFZ5RZYM35WMMLZFZDWCVP7FANCNFSM5XGZUSHA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABQ2PKE7DXLCGJ6PE43K5PDWCVP7FA5CNFSM5XGZUSHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJP4ZVHQ.gif Message ID: @. @.> >
Request that the term "public prision" be corrected to "prison" and, as it seems unnecessary, remove the adjective "public." Thanks - Sam Smith - working with U of Michigan Medical Research Center (We will be referencing this ontology for a paper on Occupation Ontology.)