EnvironmentOntology / envo

A community-driven ontology for the representation of environments
http://www.environmentontology.org
Creative Commons Zero v1.0 Universal
132 stars 51 forks source link

Cleaning up ID range file #1372

Closed pbuttigieg closed 7 months ago

pbuttigieg commented 2 years ago

Addressing #1370

Note the more descriptive entries for pattern ranges.

There are pattern definitions (here) that are not allocated clear ranges.

Please create these ranges if you are responsible for the pattern (I see some from @cmungall @turbomam)

⚠️ Note the mismatch between the patterns available in YAML and those actually deployed in the module directory. If they're not deployed / used, I'll delete those patterns (or keep them in a archive directory)

@kaiiam you have a range for your pattern generated terms, but this doesn't identify which patterns are used. Could you replace the former with individual ranges for the patterns themselves?

turbomam commented 8 months ago

This looks good to me. Since this PR was created, @aclum and I split up most of

Datatype: idrange:25

    Annotations:
        allocatedto: "National Microbiome Data Collaborative"

    EquivalentTo:
        xsd:integer[>= 3600000 , <= 3600099]

into

Datatype: idrange:28

    Annotations:
        allocatedto: "Alicia Clum"

    EquivalentTo:
        xsd:integer[>= 3600100 , <= 3604999]

Datatype: idrange:29

    Annotations:
        allocatedto: "Mark Andrew Miller"

    EquivalentTo:
        xsd:integer[>= 3605000 , <= 3609999]
turbomam commented 8 months ago

There's currently a merge conflict on

Datatype: idrange:25

    Annotations:
        allocatedto: "Terms generated by design pattern: entity_attributeA"