EnvironmentOntology / envo

A community-driven ontology for the representation of environments
http://www.environmentontology.org
Creative Commons Zero v1.0 Universal
127 stars 53 forks source link

problematic logical definition for freshwater wetland ecosystem #1382

Open cmungall opened 1 year ago

cmungall commented 1 year ago

http://purl.obolibrary.org/obo/ENVO_00000243

A wetland which is inundated with water that contains low concentrations of salts.

'wetland ecosystem' and 
  ('has part' some 
     ('planetary landmass' and 
        ('composed primarily of' some 
            (soil and ('has part' some 'fresh water')))))

The logical definition does not match the textual definition (S11 violation)

The logical definition likely is trivially satisfied for not freshwater ecosystems in a few different ways:

I always recommend against heavily nesting OWL as the resulting models almost always deviate from what is intended (Remember, with OWL and FOL an equivalence axiom has hold absolutely). This especially holds where the signature includes mass nouns/substances or qualitative terms

cmungall commented 12 months ago

let me know how I can help. My recommendation is that the equivalence axiom is removed. I can make this PR. But I want to avoid making PRs that are not in line with documented ENVO design principles