EnvironmentOntology / envo

A community-driven ontology for the representation of environments
http://www.environmentontology.org
Creative Commons Zero v1.0 Universal
132 stars 51 forks source link

Issue 1251 #1390

Closed pbuttigieg closed 1 year ago

pbuttigieg commented 1 year ago

Supercedes #1252

cmungall commented 1 year ago

Hi @pbuttigieg

Unfortunately reviewing this PR is very difficult as it was started from an old PR and has many of the changes that happened on master merged in, so everything is all mixed together in the PR.

I'm going to consult with some others on the best way to proceed here. (There are many approaches ranging from cherry picking through to rebasing through to simply redoing the work). I will report back later.

cmungall commented 1 year ago

It looks like all intended changes were in one commit. I did a diff of this to help us review: diff.txt

cmungall commented 1 year ago

This is a really important PR. There are lots of much needed changes in these, for example, moving a lot of currently very useful classes from immaterial to material entities. I'm going to prioritize rescuing this.

cmungall commented 1 year ago

Replaced by #1430