EnvironmentOntology / envo

A community-driven ontology for the representation of environments
http://www.environmentontology.org
Creative Commons Zero v1.0 Universal
132 stars 51 forks source link

Which foodon classes should be imported into ENVO #614

Open cmungall opened 6 years ago

cmungall commented 6 years ago

Currently we maintain a curated list imports/foodon_terms.txt, based on terms that were originally in envo. What is the criteria for adding/removing from that list? Is it terms that may be used for microbial sample annotation? Shouldn't the approach here be to have MIXS include FOODON as a recommended ontology? Or should we make shadow environment classes for our subset?

Currently we have a single explicit reference to FOODON, for mushroom, see #464, where we define 'mushroom environment'

image

this just seems weird. Don't we want to use FAO_0000012 "basidiocarp" instead?

pbuttigieg commented 6 years ago

Currently we maintain a curated list imports/foodon_terms.txt, based on terms that were originally in envo. What is the criteria for adding/removing from that list? Is it terms that may be used for microbial sample annotation? Shouldn't the approach here be to have MIXS include FOODON as a recommended ontology? Or should we make shadow environment classes for our subset?

MIxS and MEO both reference food environments heavily. Importing back into ENVO was partially a convenience thing, so MIxS users wouldn't have to hunt in two ontologies. However, it's more correct to create the shadow classes (as those users are talking about the environments determined by the food), perhaps with a DSODP driving?

this just seems weird. Don't we want to use FAO_0000012 "basidiocarp" instead?

This makes more sense, the FOODON ref was historical inertia.