search

EnvironmentOntology / envo

A community-driven ontology for the representation of environments
http://www.environmentontology.org
Creative Commons Zero v1.0 Universal
132 stars 51 forks source link

NTR:hydrocarbon-based oil #850

Open kaiiam opened 5 years ago

kaiiam commented 5 years ago

We currently have oil with def:

A nonpolar, hydrophobic, and lipophilic material which is a viscous liquid at ambient temperatures (about 20 degrees Celsius) or slightly warmer.

Hence one would assume this class is meant for any type of oil could be olive oil or petroleum. However this class contains the axiom:

'composed primarily of' some hydrocarbon

Hence I propose we make new class hydrocarbon-based oil subclass to oil and move that axiom mentioned above to the new class.

I realize that a class like olive oil wouldn't belong in ENVO but rather in foodon under their lipid food product hierarchy. If @pbuttigieg you don't think there is scope for a general purpose oil class in envo, then I think we should at least update oil's label to hydrocarbon-based oil and change the definition accordingly.

kaiiam commented 5 years ago

@dr-shorthair I've tagged this issue with the Hazards label as it needs addressing to service #844

dr-shorthair commented 5 years ago

Yeah, I could see the provenance, though I suspect it is a more foundational requirement than just for hazards