search

EnvironmentOntology / envo

A community-driven ontology for the representation of environments
http://www.environmentontology.org
Creative Commons Zero v1.0 Universal
132 stars 51 forks source link

new classes: porosity of snow and porosity of ice #923

Closed rduerr closed 2 years ago

rduerr commented 4 years ago

Similar to "porosity of soil" and needed for Proposed Cryo extension MIxS_Cryo (see https://docs.google.com/spreadsheets/d/12tpxkZ8_t14hND2McHxAV_hxMCda_VTxJBWUoVLzAIw/edit#gid=1069717080).

Also, see #894 - where comment about the difference between porosity and permeability is right on the money. They are distinct qualities.

kaiiam commented 4 years ago

@pbuttigieg I can create these using the entity_attribute DOSDP module, unless you think more is needs to be captured then the simple pairings. Looks like the straightforward case to me.

pbuttigieg commented 2 years ago

Thanks @kaiiam - The pattern would work i think. We can decorate with comments in the envo-edit graph.

Was this not done in the cryohackathons though?

kaiiam commented 2 years ago

Looks like it wasn't done. It's not in envo-edit. I presume this would have been part of the ESIP cryo term set as @rduerr requested them.

In theory the patterns are great an easy until there are various PRs that each independently modified the pattern differently, but luckily that didn't seem to be the case with https://github.com/EnvironmentOntology/envo/pull/1330/files and https://github.com/EnvironmentOntology/envo/pull/1336/files on the entity_attribute_location.csv file. I remember this happening in the past though and being a pain. If we're safe to now make a new PR modifying the EA pattern csv file then this is a simple fix. I've briefly looked though all our open PRs and I don't see any that modify the EA pattern csv so I think we're safe to add a PR with it now.

kaiiam commented 2 years ago

PR submitted, see https://github.com/EnvironmentOntology/envo/pull/1341, some diff issues arise with the pattern however, see the thread on the new PR.