search

EnvironmentalDashboard / community-voices

Community Voices communication technology combines images and words to advance environmental, social and economic sustainability in diverse communities.
https://environmentaldashboard.org/community-voices/
2 stars 1 forks source link

CV embeddable #76

Closed acrap5 closed 3 years ago

acrap5 commented 3 years ago

Most recent changes to the CV embeddable, including the transparent grey circle behind slider arrows, adjustment of various spacing issues, and addition of the search bar through #search. Pertains to https://www.notion.so/Create-CV-embeddable-db4dbb9dc44c414083d723e0610f01ec as well as https://www.notion.so/Add-grey-circle-behind-arrow-sliders-bf6e343f07ff49548546711c7607c312.

Sammidysam commented 3 years ago

Code all looks good - I like the CSS variable! I've never used those (rip IE though, but oh well). I had some issues with getting both buttons and the search to show up and to still have everything fit on the page. Could you check out the attached video and let me know if anything isn't right? https://drive.google.com/file/d/1AXJlxv4AhOuE8r7x_Uqf08rZnhhj1cXc/view?usp=sharing

Also, maybe the current search term should fill into the search bar to show what is being searched currently?

acrap5 commented 3 years ago

That is strange, on my system everything fits as intended, and everything should be proportional. That is, I don't think any dimensions are fixed, so it should work on every screen?

Sammidysam commented 3 years ago

I would imagine the sizing issue may still exist with my computer, but it is a bug for another person. Merging.