search

EnzymeAD / Enzyme.jl

Julia bindings for the Enzyme automatic differentiator
https://enzyme.mit.edu
MIT License
437 stars 62 forks source link

Load Adapt unconditionally for Julia 1.8 #1369

Closed vchuravy closed 5 months ago

vchuravy commented 5 months ago

Needs backport to EnzymeCore 0.6

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.41%. Comparing base (ed0ea50) to head (2e89005). Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1369 +/- ## ========================================== + Coverage 75.37% 75.41% +0.03% ========================================== Files 35 35 Lines 10655 10664 +9 ========================================== + Hits 8031 8042 +11 + Misses 2624 2622 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wsmoses commented 5 months ago

Some folks in the past were hesitant about adding EnzymeCore as a dep due to Adapt as a sub-dependency, so I'm a bit hesitant here.

vchuravy commented 5 months ago

So the question is what is their concern? Is it load time? If so package extensions solves that but it can only solve it on 1.9+

I strongly think that we shouldn't have broken functionality on 1.8 and lower

wsmoses commented 5 months ago

Okay. I'm a bit uneasy on this still, but I defer to your judgement.