search

EnzymeAD / rust

A rust fork to work towards Enzyme integration
https://www.rust-lang.org
Other
52 stars 7 forks source link

chore: Use correct commit hash as github cache key if submodule is not checked out #107

Closed I-Al-Istannen closed 3 months ago

I-Al-Istannen commented 3 months ago

Previously, the CI workflow file used git -C src/tools/enzyme to try and execute a rev-parse inside the submodule. Unfortunately, this only works if that submodule is actually checked out and enzyme does not specify that. I am not quite sure where they are checked out at all, but clearly they are at some point. The commit hash chosen for the key https://github.com/EnzymeAD/rust/issues/86#issuecomment-2028812352 here is neither the new nor the old enzyme commit, so this evidently didn't quite work out.

This PR changes the lookup to refer to the submodule instead, which should work regardless of its status on disk.

ZuseZ4 commented 3 months ago

Rust (x.py) will check out submodules when building rustc - at least iirc.

Per discussion, postponed till the weekend.