EnzymeML / PyEnzyme

🧬 - Data management and modeling framework based on EnzymeML.
BSD 2-Clause "Simplified" License
23 stars 9 forks source link

init_conc argument with `Replicate()` is redundant #11

Closed jmrohwer closed 3 years ago

jmrohwer commented 3 years ago

The init method signature for the Replicate() class has an argument init_conc:

class Replicate(EnzymeMLBase):

    def __init__(
        self,
        replica,
        reactant,
        type_,
        data_unit,
        time_unit,
        reaction=None,
        measurement="unspecified",
        init_conc="NONE",
        data=None,
        time=None,
        isCalculated=False,
        uri=None,
        creatorId=None
    ):

This is, however, redundant and should be removed in my opinion to avoid confusion.

JR-1991 commented 3 years ago

Thanks for pointing this out! Indeed the init_conc argument is redundant now regarding the addition of the new Measurement class. The argument and all corresponding methods were removed in commit e3732e6.