Closed JR-1991 closed 2 years ago
ideally the same things would apply to the COPASI thin layer as well, could we find a way to have the same methods be present on the base class, so that things just work for every modelling tool?
ideally the same things would apply to the COPASI thin layer as well, could we find a way to have the same methods be present on the base class, so that things just work for every modelling tool?
I agree, that would be great to have a similar structure in the COPASI thin layer. Are you thinking about to adapt the optimization preparation or complete process in terms of methods? Should we implement this into the base class as well?
We should also think about to allow an EnzymeMLDocument object as an alternative input. Currently some tests are failing due to files not found and providing a document object as fixture would help.
currently the method you introduced here into the base class write
, is in the COPASI TL as def update_enzymeml_doc(self):
there i also did not return the enzymeml document in optimize and the update method, as it is available from the class at any point.
And yes, having a constructor that takes an enzyme ml document, instead to always have to read from archive would be a good idea.
The PySCeS Thin Layer has been adapted to the BaseThinLayer class and utilizes the
__init__
-method given in the class.optimize
andwrite
to perform parameter estimation and writing the gathered parameters to a newEnzymeMLDocument
instance.enzmldoc.applyModelInitialization
-method which takes the values from a YAML file.value
-attributeExample usage:
This change is