search

EnzymeML / PyEnzyme

🧬 - Data management and modeling framework based on EnzymeML.
BSD 2-Clause "Simplified" License
21 stars 9 forks source link

core api should not use deprecated methods #23

Closed fbergmann closed 2 years ago

fbergmann commented 2 years ago

the core api internally should not issue any warnings. It currently does on refactoring, for example:


pyenzyme/enzymeml/core/measurement.py:252: DeprecatedWarning: getData is deprecated. Use the attribute `time' and 'data` instead.
  self.global_time = replicate.getData(sep=True)[0]
pyenzyme/enzymeml/core/measurement.py:253: DeprecatedWarning: getTimeUnit is deprecated. Use the attribute `time_unit` instead.
  self.global_time_unit = (replicate.getTimeUnit())
pyenzyme/enzymeml/core/measurement.py:255: DeprecatedWarning: getTimeUnit is deprecated. Use the attribute `time_unit` instead.
  replicate.getTimeUnit())
pyenzyme/enzymeml/tools/enzymemlwriter.py:423: DeprecatedWarning: getMetaid is deprecated. Use the attribute `meta_id` instead.
  unit.setMetaId(unit_def.getMetaid())
pyenzyme/enzymeml/tools/enzymemlwriter.py:424: DeprecatedWarning: getName is deprecated. Use the attribute `name` instead.
  unit.setName(unit_def.getName())
pyenzyme/enzymeml/tools/enzymemlwriter.py:1086: DeprecatedWarning: getReplicates is deprecated. Use the attribute `replicates` instead.
  for replicate in data.getReplicates()
pyenzyme/enzymeml/tools/enzymemlwriter.py:947: DeprecatedWarning: getName is deprecated. Use the attribute `name` instead.
  measurement_annot.addAttr('name', measurement.getName())