search

EoRImaging / FHD

Fast Holographic Deconvolution
BSD 2-Clause "Simplified" License
18 stars 10 forks source link

Passing variables into filter functions #272

Closed nicholebarry closed 2 years ago

nicholebarry commented 2 years ago

If obs,psf, and params are passed into filter_uv_uniform, then the visibility count needed for weighting is calculated on the fly. If not, then the vis_count file is restored. However, the above structs were not passed into the filter function in dirty_image_generate.

I may see why...the filter function call in dirty_image_generate is general, i.e. it can call any filter function depending on input. Some of the simpler filter functions don't need obs,psf, and params to calculate their filter.

I think that it's better to not rely on I/O, so I've added the structs as passable variables in each filter function, even if they aren't explicitly needed, just so the general filter function call won't fail in dirty_image_generate. This is a matter of opinion, so please decline if you don't think it's worth it.

nicholebarry commented 2 years ago

I agree... let's not merge this.