search

EoRImaging / FHD

Fast Holographic Deconvolution
BSD 2-Clause "Simplified" License
20 stars 10 forks source link

antenna indices rewrite #285

Closed nicholebarry closed 2 years ago

nicholebarry commented 2 years ago

Quick little fix for the pyuvdata antenna naming convention. I admit that it may not be the best fix....

For starters, there is an assumption that the number of tiles would be less than antenna names, and that the antenna names are numbers. These are both assumptions that could break.

fixes #292

PyxieLouStar commented 2 years ago

fixes #292 Uses information from the antenna table in the uvfits file to calculate the number of tiles and to generate antenna numbers in the format FHD expects (specifically, that no antenna number is greater than the number of tiles). Also uses the antenna table to get antenna numbers for the case that a metafits file is not submitted.

PyxieLouStar commented 2 years ago

this branch has been tested on the mwa golden day obs 1061317032. I ran on this branch with and without the metafits file and on master with and without the metafits file on this branch. I then checked the obs and cal structures and found them to be the same for similar runs on this branch and on master.

PyxieLouStar commented 2 years ago

@dstorer will test this branch on a HERA file.