EoRImaging / FHD

Fast Holographic Deconvolution
BSD 2-Clause "Simplified" License
20 stars 10 forks source link

`fhd_struct_init_meta` and `fhd_struct_init_obs` tile flag bug #311

Open SkyWa7ch3r opened 1 year ago

SkyWa7ch3r commented 1 year ago

While translating and testing for PyFHD I noticed the tile_flag variable inside fhd_struct_init_meta ends up with indexes beyond the array during it's creation furthermore, it ends up flagging tiles different for different polarizations. the end result is in fhd_struct_init_obs when applying the meta.tile_flag to tile_use on 2 polarizations we end up with flagged tiles, while on 4 polarizations we end up with no flagged tiles.

For now in PyFHD I apply the single_i to the flag column inside the metafits file and this gets read into the meta['tile_flag'] dictionary value which then gets applied to obs['baseline_info']['tile_use'] = 1 - meta['tile_flag'], is this a suitable approach that could be done in FHD as well?

This issue can be tested with the observation 1088716176, which is one of the observations used to test PyFHD via WODEN simulations or otherwise.