search

EoRImaging / eppsilon

eppsilon - error propagated power spectrum with interleaved observed noise
BSD 2-Clause "Simplified" License
5 stars 4 forks source link

Add image_clip option, default to using the full image is used with the standard uv pixel size #111

Closed bhazelton closed 5 years ago

bhazelton commented 5 years ago

This adds an image_clip option, the old default behavior was to use the image clip (small image). This is now an option which is defaulted to off so that the full image is used with the standard uv pixel size.

There is also a full_image option, which this PR does not change, which uses the full image and smaller uv pixels set by the size of the image. Using the standard uv pixel size (the new default) means that the pixels are close to uncorrelated, which is the assumption in the rest of the code and also makes it run much faster.

nicholebarry commented 5 years ago

Does not break typical functionality. 2D plots include the updated range nicely.

nicholebarry commented 5 years ago

Functionality of default smaller, uncorrelated pixel default tested. Works great, runs fast. There is a subsequent small decrease in noise-noise ratio plot, which makes it appear closer to 1. Will need to do more testing / quantitative tests to see if we want to use this method for publication, however this branch is good to merged in the meantime.

wenyang-li commented 5 years ago

I see it is already merged. Sorry for the late notice. I have tested it and it works well in my case.