search

EoRImaging / eppsilon

eppsilon - error propagated power spectrum with interleaved observed noise
BSD 2-Clause "Simplified" License
5 stars 4 forks source link

Observation volume calculation #129

Closed nicholebarry closed 4 years ago

nicholebarry commented 4 years ago

The observation volume calculation was being performed over the full band. If a subband is chosen, it should be calculated only over that subband.

This does effect the published limits. Thankfully, it is small. For example, lowest limit from Barry et al 2019b for z=7 (lower freqs than average) was 3890.4814 mK^2, but should be 3745.1896 mK^2. I think that means that Wenyang's limits from the z=6.5 band (high freqs than average) should be a little higher than they should be.

I also removed some backwards-compatibility stuff that is probably no longer necessary.

bhazelton commented 4 years ago

This looks good, but we should also fix this for the window_int_beam calculation, which is another way to calculate the observation volume. I believe the third way (which uses the variance cube) should already work properly because those cubes are cut down to the freq_ch_range.

nicholebarry commented 4 years ago

Upon inspection, the vanilla implementation of window_int_beam was fine. However, I opened up a can of worms when I investigated the more interesting flavors...

Specifically, the code broke when both a frequency channel range and frequency flags were specified. I had to go through and make sure order and file naming were right.

Tested and works. Ready for merge

nicholebarry commented 4 years ago

poke @bhazelton @jpober

nicholebarry commented 4 years ago

@bhazelton No change given those lines.

Can you approve?