search

Eoin-ONeill-Yokai / Godot-RichTextEffect-SampleProject

This is a test project for the new godot RichTextEffect class. It also comes with some example implementations of custom text effects. View README for details.
39 stars 7 forks source link

Center the sounds #1

Closed Type1J closed 5 years ago

Type1J commented 5 years ago

Hello, this is a great project! It's certainly going to be used by me for plenty, especially the custom effects!

I did have 1 issue with the example, though. Because an AudioStreamPlayer2D is used, the pan of the sound is dependent on the position in the 2D scene. It looks like the node was added, but never really positioned. If you have mono sound, you might not notice, but because (0, 0) is the left side of the screen, I was getting all of the audio out of the left speaker.

I positioned the AudioStreamPlayer2D nodes in the center of the viewport, and they're now playing in the center. I guess this could be positioned to the center of the text area, but I was just trying to get it to sound passable for demo purposes. Here's a pull request with those changes (very minor).

Eoin-ONeill-Yokai commented 5 years ago

Sure, this can be merged. I may come back later and change this to be a non-positional sound too though.

Thank you for taking the time to contribute!