search

Eomm / fastify-raw-body

Request raw body
MIT License
44 stars 10 forks source link

Raw body support for application/ld+json and application/activity+json #59

Closed perillamint closed 10 months ago

perillamint commented 10 months ago

This PR implements raw body support for application/ld+json and application/activity+json

Eomm commented 10 months ago

Thanks for the PR

Why it is closed now?

perillamint commented 10 months ago

I found it causes some trouble with preexisting handlers in some cases. For example: https://github.com/misskey-dev/misskey/commit/04075ee0bede198452dcd5e8ca6a00a3b750208b

I think this should be handled in a better way (or should state that it breaks some compatibility)

perillamint commented 10 months ago

I re-opened it but put it in draft state

Eomm commented 10 months ago

I think this should be handled in a better way (or should state that it breaks some compatibility)

The best approach would be to accept a new user's config to set the content type.

Please, add some tests too

perillamint commented 10 months ago

Done! Could you review this patch set? @Eomm