Eonasdan / tempus-dominus

A powerful Date/time picker widget.
https://getdatepicker.com
MIT License
7.16k stars 4.4k forks source link

Support WCAG2.1 accessible tool #2390

Closed Eonasdan closed 10 months ago

Eonasdan commented 3 years ago

Hi @Eonasdan, I have checked docs but couldn't find anything related. Is v6 will support WCAG2.1? In other words will it be an accessible tool?

Originally posted by @kiliczsh in https://github.com/Eonasdan/tempus-dominus/discussions/2384#discussioncomment-1275978

Eonasdan commented 3 years ago

@kiliczsh The icons have title attributes but I haven't done much with accessibility. That's a good idea though.

kikonen commented 2 years ago

The thing is that "keyboard accessibility" is mandatory requirement in various places, just due to legalize rrequirements (like ADA in USA).

Eonasdan commented 2 years ago

Hello there's a new branch: https://github.com/Eonasdan/tempus-dominus/tree/feature/accessibility that features keybindings. It's not done but some progress has been made. The keybindings only seem to work via the input field not when focus is on the widget div. If you want to take a look, feel free!

Eonasdan commented 2 years ago

Please check the progress of this feature here: https://stackblitz.com/edit/tempus-dominus-v6-accessibility?file=index.html

I could use some feedback on what's missing and what's working.

kikonen commented 2 years ago

I will try to look into it

kikonen commented 2 years ago

First notice, if input group with button, is used also to open popup, it must be accessible also via that (FYI, also "button" must be implemented as button, span is fail in ADA tests). Not it seems that when popup is opened via button then keyboard access won't work. Perhaps should move focus back to input field when opening popup (?). I.e. end user most likely tries TAB, not SHIFT+TAB.

"toolbar" at top and "time select" at bottom are not TABable seemingly currently, while actionable via mouse (yep, counted as "fail" in ADA tests).

i.e. basic rule is that everything accessible via mouse must be accessible also via keyboard (and yes, been there and there can be thus cases, which don't make much sense, but when audit is done by external auditor, they just do it with "brains turned off").

Furgas commented 2 years ago

This could be useful for "how it should work": https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/datepicker-dialog.html

mlalpho commented 2 years ago

This could be useful for "how it should work": https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/datepicker-dialog.html

This page moved to https://www.w3.org/WAI/ARIA/apg/example-index/dialog-modal/datepicker-dialog.html

chardin1 commented 5 months ago

@Eonasdan What's the status of this feature? I see you marked it as complete in December but the branch doesn't appear to have been merged and released.

Eonasdan commented 5 months ago

@chardin1 I'm no longer working on this project. I've moved on to other things. If someone wants to discuss sponsoring this issue, I'd be open to that.

MartinRiese commented 1 month ago

@Eonasdan We are interested in sponsoring accessibility improvements. What is the best way to contact you about the specifics? My email address is mriese@dimagi.com, if you want to use email.