coderabbitai[bot]
commented
2 weeks ago [!CAUTION]
Review failed
The pull request is closed.
📝 Walkthrough
📝 Walkthrough
## Walkthrough The changes made in this pull request primarily focus on enhancing the `print` method within the `Printer` class, improving the logic for handling free pages and cost calculations. The method now checks for sufficient balance before calculating costs, ensuring more accurate error handling. Additionally, new entries have been added to language resource files for both English and Hungarian, clarifying that print jobs cannot mix free and paid methods. A corresponding message has also been integrated into the Blade template to inform users of this policy. ## Changes | File | Change Summary | |-----------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | app/Utils/Printer.php | Restructured the `print` method to calculate total pages earlier and check for sufficient balance before cost calculation. Updated error handling for insufficient balance and revised comments for clarity. | | resources/lang/en/print.php | Added new entry: `'payment_methods_cannot_be_mixed' => 'A print job can be either free or paid as they cannot be mixed.'` | | resources/lang/hu/print.php | Added new entry: `'payment_methods_cannot_be_mixed' => 'Egy nyomtatás vagy ingyenes vagy fizetős lehet, nem keverhető.'` | | resources/views/dormitory/print/print.blade.php | Introduced a new paragraph in the Blade template to display the message related to the payment methods, using the translation key `print.payment_methods_cannot_be_mixed`. No changes to existing functionality or structure. |Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
horcsinbalint
Description
There is a quite annoying bug where if a user prints using free pages, their free page pool is only decreased by p and not by n*p (where n is the number of copies, and p is the number of pages in the document). The quickest and easiest way of dealing with it is to only allow a print job to be fully paid or entirely free and deduct the printed pages correctly. The solution is not ideal but it is quite a rare occurrence where someone would like to use both free pages and pay for the remainder. (They can split it themselves.)
This bug is quite annoying as our registry shows only a fraction of the actual usage. I.e. ~ 5000 sheets was loaded into the printer during this semester, and our Mars instance shows only a few hundred printed pages. It would be crucial to understand how many pages were printed for different kinds of activities as it has already eaten roughly a quarter of our budget of the semester in half-a-semester.
Changes
Additional Notes
I am not refactoring the printer module for this PR. To allow mixing these methods, the
PrintAccountclass would also need to be refactored but I do not think that it is worth the time to be invested as we will need additional refactoring as we are planning on introducing multiple printers.