Ep8Script / Club_Penguin_Minigames

Minigames from Club Penguin recreated in HTML5!
https://clubpenguin-minigames.ep8script.com
27 stars 8 forks source link

Brighten Sled Racing Background #3

Closed Aurorum closed 4 years ago

Aurorum commented 4 years ago

Hi @Ep8Script! 👋 I was playing Sled Racing again yesterday and felt that the darkness of the Sled Racing background was a bit distracting.

Screenshot 2020-03-09 at 21 55 44

I wondered if it was worth changing the background to something Sled Racing related? I also removed the sky image since it was creating a border beneath the game; it can be recreated with a background gradient.

Screenshot 2020-03-09 at 21 50 54

Let me know what you think? :)

Ep8Script commented 4 years ago

Ooh, thank you very much for this! I'll check it out in a few hours. The black bars are definitely annoying, it's a side effect of me developing this on a laptop where it actually doesn't have the space at the bottom. I'm glad I got it to display the same ratio correctly at all but if you wanna find a way to have it fill the screen correctly, feel free!

Same goes with Bean Counters I guess since at 100% (default) zoom in most browsers, it doesn't look right on a bigger screen either lol, you need to use 150%.

And thank you for the gradient background, that's really cool! What was the border issue...?

Also this project is being brought back soon, I'm gonna start working on another minigame this week. I hope you'll like it :D

Aurorum commented 4 years ago

Hi! I'll take a look at trying to expand it tonight but it could be difficult since I'm not sure how you got the ratios to work so perfectly tbh!

I think you can see the border at the bottom more easily currently with the black background; the sky currently causes a blue border at the bottom. It's a bit odd because it's only the bottom, and it doesn't really work as well when there's a background.

Screenshot_20200310-061813

And nice, I'm curious to see what else you'll be working on! :)

Ep8Script commented 4 years ago

Okay cool! I'm gonna merge your PR now (and make a couple of fixes), it's good, thanks for your help! And yeah I have no idea either tbh lol, but it works well and it's definitely necessary (easy to tell by editing the div to expand and yeah... it's not pretty)

Gotcha, that makes sense! I assume the sky image was a little too big 😅

Hopefully it'll be done in the next few weeks :D

Aurorum commented 4 years ago

Yeah, I guess it was too big. But this also does allow to change the colour of the sky in the future...night mode? 🙂

Thanks Jess!

Ep8Script commented 4 years ago

Yeah haha oops, and I suppose it does!! That could be interesting, could slightly dark the penguins or something, haha.

You're welcome, and also that was hilarious!! I was hopping on to make sure the CSS changes were working, and I saw the player countdown and I was like wait... did it not register I left the room? And then I see your name 😂

Aurorum commented 4 years ago

You only just won by a few milliseconds! I wasn't expecting that either...I was playing with a broken game from trying to make it full screen! :D

Ep8Script commented 4 years ago

Yeah it was so close haha, and that makes sense, I hope it didn't hinder you too much :P

Ep8Script commented 4 years ago

@Aurorum heya, the new game is out btw!!

Aurorum commented 4 years ago

Pizzatron! 🍕 I played it last night and it was really good! Nice work! :)

Ep8Script commented 4 years ago

Nice!! Thanks, I'm glad :D