search

Ephellon / Twitch-Tools

Adds extra features to Twitch
https://chrome.google.com/webstore/detail/ttv-tools/fcfodihfdbiiogppbnhabkigcdhkhdjd
GNU General Public License v3.0
21 stars 2 forks source link

Suggestion: Re-express "Lurk" button's intent #25

Closed Mishasama closed 3 months ago

Mishasama commented 3 months ago

Describe the bug

After test: When it shows "Turn lurking off" the volume is normal. When it shows "Turn lurking on" the volume is set low. It confuses me.

To Reproduce

  1. Reload the tab
  2. Click on 'Lurking' button
  3. Click it again
  4. See the error?

Expected behavior

Should make it clear what state for now. For example, "Lurking is ON" or "Lurking is OFF"

Screenshots

image image

Extension Information

Additional comments

Ephellon commented 3 months ago

The text is clear... The provided example just flips the status text...

Turn lurking off — Release volume control (return to what the user had) Turn lurking on — Take control of the volume (set it to the Lurking Volume setting)

image

Mishasama commented 3 months ago

I mean... Turn lurking off = Turned lurking off? Press the button to turn the lurking off? The "Turn" is a verb. or a nom.?

I think ambiguity should be avoided as much as possible, right?

Ephellon commented 3 months ago

Yes, the message should be short and unambiguous. Just as Twitch has the Follow and Unfollow buttons.

Turn lurking off implies it is already enabled—pushing the button will turn it off.

The best, alternative solution would be single-word replacements:

Mishasama commented 3 months ago

I prefer Lurk & Unlurk. Short & clear. And it's consistent with Twitch's phrasing conventions.