search

Ephemerality / xray-builder.gui

A .Net application that processes e-books to create X-Ray files for the Amazon Kindle (Paperwhite, Voyage, Fire). X-Rays are built complete with chapter locations and excerpts.
MIT License
66 stars 9 forks source link

Fix: Removed comma from "all reviews" number #28

Closed Tavisco closed 7 years ago

Tavisco commented 7 years ago

Hi! When I was using this software I had an error at runtime: error1

So, I forked the project and started debuging it, the problem was that the value was coming with a comma, as you can see: error1_det

So, I've copied the code from some lines below that remove commas and the code worked as expected!

And fixed regex (in Goodreads.cs) for books that have more than 1M passages and highlights.

Ephemerality commented 7 years ago

Hi there! This should be fixed in the latest commit of the beta branch (rather than the darrenmcgv3 branch) - 9c56d1759e5031c54af55016709c7e895af4029b. I tweaked what you had done a bit to handle (hopefully) all possible cases.
The issue here was that the AllowThousands option made it expect the separator for your locale (decimal point, I assume) but was seeing commas from Amazon.com and failing.
Thanks for your interest in this project!