search

Ephemerality / xray-builder.gui

A .Net application that processes e-books to create X-Ray files for the Amazon Kindle (Paperwhite, Voyage, Fire). X-Rays are built complete with chapter locations and excerpts.
MIT License
65 stars 9 forks source link

Characters names with accented letters are not encoded correctly #37

Closed akrabi closed 4 years ago

akrabi commented 4 years ago

When a book in Goodreads contains a character whose name contains accented letters, those letters are not encoded correctly and the wrong characters are displayed instead in the aliases file.

Example: Book url: https://www.goodreads.com/book/show/25454056-sword-of-destiny?ac=1&from_search=true&qid=FTvOuHMSCW&rank=1 Character name: Eithné Aliases file character name: Eithné

Ephemerality commented 4 years ago

Ouch, yeah sorry about that. Which version are you using? Your PR is going to master but master's waaaay out of date.

akrabi commented 4 years ago

Ouch, yeah sorry about that. Which version are you using? Your PR is going to master but master's waaaay out of date.

This was on the latest release. Which branch should I base my PR on?

Ephemerality commented 4 years ago

I pushed the same fix to the beta branch before I realized you had opened a PR at the same time (release here: https://github.com/Ephemerality/xray-builder.gui/releases/tag/2.1.114)

Ephemerality commented 4 years ago

If for some reason you're using an old release we can push it to master too otherwise it can wait until I'm done with the current beta. Thanks!

Edit: I merged it anyway, nbd. There are probably still spots where I've forgotten to use UTF8 as well.