search

Ephenia / Pokeclicker-Scripts

Various scripts & enhancements for the game Pokéclicker.
https://github.com/Ephenia/Pokeclicker-Scripts
GNU General Public License v3.0
184 stars 263 forks source link

Desktop proofing against race conditions #326

Closed umbralOptimatum closed 11 months ago

umbralOptimatum commented 11 months ago

Small patch to prevent potential race conditions if a user tried to load their save before all scripts had been executed. The game will now only load once all scripts have run.

Ephenia commented 11 months ago

Once this gets a decent amount of testing and if all is checking out I have no issue passing it through regardless of votes.

Ephenia commented 11 months ago

Still looking to see feedback on this, please post/comment if you have tried using this or just vote on it if it makes it easier and you found no issues with it.

umbralOptimatum commented 11 months ago

I've been using this version with no issues. The only difference for users is it should have fewer edge case failures, so I'd be surprised if anyone noticed a difference. (I'd also be surprised if anyone installed this before an official release, honestly.)

Ephenia commented 11 months ago

This will be merged and approved now.