Ephenia / Pokeclicker-Scripts

Various scripts & enhancements for the game Pokéclicker.
https://github.com/Ephenia/Pokeclicker-Scripts
GNU General Public License v3.0
184 stars 263 forks source link

PokeClicker update v.0.10.14. broke some scripts #342

Closed K0STYURIK closed 10 months ago

K0STYURIK commented 10 months ago

SyntheticShinySynapse and IniniteSeasonalEvents both not appear in the menu at all. Not functioning both on desktop and on browser

EnhancedAutoClicker works fine with wild Pokemon, but AutoGYM and AutoDungeon only work in browser version, on desktop version autoclicking in GYMs and dungeons is stuck (timer is stuck too for some reason).

Not sure if is a right place to mention it, but buttons from AutoSafariZone script by Kanzen01 not appearing in browser at all. Activating AutoSafariZone on desktop doesn't do anything.

umbralOptimatum commented 10 months ago

I haven’t had any issues with Auto Gym or Auto Dungeon on desktop. What specifically are you trying to use them for? Can you provide the console log?

I’ll probably fix Infinite Seasonal Events (and Simple Weather Changer) soon so logs for that would be appreciated as well. Synthetic Shiny Synapse is outside my scope.

Bug reports for the Auto Safari Zone script are better off in the PR as it’s not yet an official script.

tisserm commented 10 months ago

I also have the timer issue, but on browser version so I don't know if the problem is the same (I use Firefox btw). It is stuck in dungeons, battle frontier, flutes, items and so on -> it completely prevents battle frontier and farm from working in my case.

Not OP but i have the following error for IniniteSeasonalEvents:

TypeError: SpecialEvents.newEvent is not a function initEvents moz-extension://57920583-cd2e-443e-b92f-58215958bb9f/userscripts/[Pokeclicker]-Infinite-Seasonal-Events.user.js?id=78c27b44-8dd5-4834-ba41-6236650bc9ac:31 hideSplashScreen moz-extension://57920583-cd2e-443e-b92f-58215958bb9f/userscripts/[Pokeclicker]-Infinite-Seasonal-Events.user.js?id=78c27b44-8dd5-4834-ba41-6236650bc9ac:238 hideSplashScreen moz-extension://57920583-cd2e-443e-b92f-58215958bb9f/userscripts/[Pokeclicker]-Oak-Items-Unlimited.user.js?id=5a4fa68f-f6ee-4b7c-b821-eaaac7439f29:36 hideSplashScreen moz-extension://57920583-cd2e-443e-b92f-58215958bb9f/userscripts/[Pokeclicker]-Overnight-Berries.user.js?id=8e53f5fb-9f09-42da-9949-18af5cc0e4f3:214 hideSplashScreen moz-extension://57920583-cd2e-443e-b92f-58215958bb9f/userscripts/[Pokeclicker]-Perky-Pokerus-Pandemic.user.js?id=fb8261eb-ee70-4309-a943-205522877a37:49 hideSplashScreen moz-extension://57920583-cd2e-443e-b92f-58215958bb9f/userscripts/[Pokeclicker]-Simple-Weather-Changer.user.js?id=f7b089f1-b85d-4449-8509-f5857765df9d:67 start https://www.pokeclicker.com/scripts/script.min.js?v=0.10.14:37 promise callbackstart https://www.pokeclicker.com/scripts/script.min.js?v=0.10.14:19 getTrainerCard webpack://pokeclicker/./src/modules/profile/Profile.ts?:43 getTrainerCard webpack://pokeclicker/./src/modules/profile/Profile.ts?:35 getTrainerCard webpack://pokeclicker/./src/modules/SaveSelector.ts?:70 loadSaves webpack://pokeclicker/./src/modules/SaveSelector.ts?:24 loadSaves webpack://pokeclicker/./src/modules/SaveSelector.ts?:23 \ https://www.pokeclicker.com/scripts/script.min.js?v=0.10.14:5553 EventListener.handleEvent https://www.pokeclicker.com/scripts/script.min.js?v=0.10.14:5541

K0STYURIK commented 10 months ago

I haven’t had any issues with Auto Gym or Auto Dungeon on desktop. What specifically are you trying to use them for? Can you provide the console log?

Now EnhancedAutoClicker on desktop doesn't work for me at all. It is enabled in settings Image 001 But there are nothing on the wild Pokemon screen (there was usual AutoClicker UI when I opened game the last time) Image 002 Nothing in dungeons Image 003 Nothing in gyms Image 004 For some reason timer is still.

Working totally fine on browser.

I'd be glad to provide the console log if you teach me how to do it

K0STYURIK commented 10 months ago

Bug reports for the Auto Safari Zone script are better off in the PR as it’s not yet an official script.

Me and other person (Suitov) already commented in AutoSafariZone PR, I just mentioned it here in case it's somehow related, and the problem with other three scripts causing the problem with AutoSafariZone or vise versa

Player24826 commented 10 months ago

My farm has froze since the update.

Player24826 commented 10 months ago

Keep in mind I know nothing of code but could the time related code have been moved to the app.asar file?

umbralOptimatum commented 10 months ago

Generally when timers break it's because a script caused a big enough error to interrupt the game's main timekeeping loop. This makes it hard to identify bugs just from listing what's broken, since a small script can easily fail unnoticed but break something fundamental so that everyone reports the ripple effects, like in this case the autoclicker not working.

Thus why it's very important to provide a full list of installed scripts in bug reports, to narrow down which script(s) are causing the issue, and preferably a console log to narrow down which part of the problematic script needs fixing.

I'd be glad to provide the console log if you teach me how to do it

ctrl+shift+i on desktop, usually. You can filter to just show warnings and errors as described here.

Me and other person (Suitov) already commented in AutoSafariZone PR, I just mentioned it here in case it's somehow related, and the problem with other three scripts causing the problem with AutoSafariZone or vise versa

The Safari Zone had some changes this update, so if it's not breakage from another script it's probably due to that.

Keep in mind I know nothing of code but could the time related code have been moved to the app.asar file?

It could not. The app.asar file is only part of the desktop app and does not include the game's code itself. What scripts are you running? Try disabling them one at a time to find the one causing problems.

Player24826 commented 10 months ago

Screenshot 2023-08-21 005108 Screenshot 2023-08-21 005218 Screenshot 2023-08-21 005406

Player24826 commented 10 months ago

It was Infinite Seasonal Events script that broke.

JohnyDL commented 10 months ago

So here I have all the scripts running image

? Additional Visual Settings -> Nothing looks different probably works ? Auto Battle Frontier -> Not doing the battle frontier yet in this run Y Auto Battle Items N Auto Quest Completer -> I had a full list of quests but back to vanilla questing N Auto Safari Zone -> This is what I was focusing on now not there Y Catch Filter Fantasia Y Catch Speed Adjuster Y Challenge Mode Changer Y Discord Code Generator Y Enhanced Auto Clicker Y Enhanced Auto Hatchery Y Enhanced Auto Mine ? Infinite Seasonal Events -> Not sure where this is located ? Oak Items Unlimited -> have all items don't want to remove any incase I can't put them back ? Omega Protein Gains -> not enough vitamins to test ? Overnight Berries -> not got any offline time to test with Y Perky Pokerus Pandemic Y Simple Auto Farmer N Simple Weather Changer -> no dropdown to change weather

I have these errors in console image image image

Player24826 suggested infinite seasonal events was the issue so I turned it off and everything else appears to have started to work again so I can tentatively confirm that is probably the script with an issue -> though the auto safari is still broken it seems to load I'll mention that on the PR

MrShiluk33 commented 10 months ago

OmegaProtein dont work yep. So if you were over max protein before and try to add more it goes back to max possible.

K0STYURIK commented 10 months ago

Disabling InfiniteSeasonalEvents fixes the problems with Autoclicker and SyntheticShinySynapse

MrShiluk33 commented 10 months ago

@K0STYURIK do you think disabling InfiniteSeasonalEvents also fixes OmegaProtein ?

K0STYURIK commented 10 months ago

@K0STYURIK do you think disabling InfiniteSeasonalEvents also fixes OmegaProtein ?

Sorry, but I don't know. I never used OmegaProteinGains, so you probably should check it by yourself. Please let us know of the results anyway.

MrShiluk33 commented 10 months ago

Yeah tested it and it works without InfiniteSeasonalEvents ! @K0STYURIK

K0STYURIK commented 10 months ago

Yeah tested it and it works without InfiniteSeasonalEvents ! @K0STYURIK

Congratulations! Well, now we know InfiniteSeasonalEvents is the big bad boy breaking every other script.

umbralOptimatum commented 10 months ago

Infinite Seasonal Events patch is ready and waiting on Ephenia to merge.

MrShiluk33 commented 10 months ago

image @umbralOptimatum Pikachu (clone) isn't visible on "Mewtwo strikes back!" possible mobs available in InfiniteSeasonalEvents