New Auto Dungeon mode + misc fixes

[umbralOptimatum]

• Enhanced Auto Clicker
  • Auto Dungeon now has separate fights and chests modes
  • Open all chests without fighting every enemy or vice versa
  • New setting to open rare chests when chests mode is off
  • Rewrote script to be a class and have fewer global variables cluttering things up
  • Closes #75, closes #140, closes #197
• Additional Visual Settings
  • Fixed the dock/gym/dungeon menus allowing some sequence breaking
• Auto Safari Zone
  • Now enabled in Johto's National Park and Sinnoh's Great Marsh
  • In National Park will default to highest-average-token encounter type
  • Improved prioritization between land and water encounters
  • Closes #354, closes #358
• Scripts with their own settings menus now display in a consistent alphabetical order
• Fixed a couple rare desktop issues
• Readme updates
  • Closes #353

[elrandira]

I tried parts of your script and when I activate chest mode, my character stay stuck in the bottom left corner a dungeon.

Here's what I did (on my new computer so fresh install):

• installed tampermonkey
• installed additional visual settings, auto battle frontier, catch filter fantasia, catch speed adjuster, enhanced auto clicker, enhanced auto hatchery scripts
• updated to additional visual settings and enhanced auto clicker scripts from your repo (and only those)

as soon as I deactivate the chest mod, the character goes back on its cleaning route.

here's the console log:

line 663 of enhancedautoclicker.user.js

[elrandira]

I have some graphical issues a well:

all these issues seem related to the enhanced auto clicker script as they disappear as soon as I downgraded to the legacy version

[umbralOptimatum]

Thanks for the testing! Pathfinding issue is definitely fixed, I'm a bit embarrassed that one slipped past me. I think the graphical issues came from a limitation of userscript extensions, which is now working on my computer, but you should check it's no longer showing up for you either.

[elrandira]

script is not loading anymore :p

unsafeWindow is not defined I think

[umbralOptimatum]

unsafeWindow is built into the -monkey userscript extensions, but turns out specifically Tampermonkey on Chrome requires setting an additional permission that's helpfully not mentioned in that part of the documentation. Should be properly fixed now.

[elrandira]

I can know load the script and the chest mode is working.

but I have another issue.. the selection of the chest doesn't work:

I think Object.keys(baseLootTierChance).keys().includes(val)) should be replaced by Object.keys(baseLootTierChance).includes(val))

[umbralOptimatum]

Fixed. The second .keys() is correct, it returns the actual numeric indices, but the step that gets those in usable form (array rather than array iterator) got lost somewhere in the update process.

[elrandira]

works like a charm. thanks for the PR.

[umbralOptimatum]

Also now with Auto Safari working in the new safaris.

[umbralOptimatum]

In the Bug Catching Contest, Auto Safari now by default prioritizes encounters (i.e. grass/water) with the best average Contest Token reward for your unlocked regions.

[umbralOptimatum]

And that's enough votes!

[Ephenia]

Approved, apologies for the delay.

[lnlyssg]

Seems like there are issues with the Safari script as per #364